enable build with Maven 4 by hboutemy · Pull Request #655 · apache/maven-deploy-plugin

hboutemy · 2026-03-26T20:38:09Z

build with Maven 4 in CI, to check if maven-deploy-plugin 3.x works with Maven 4

and complete the table on https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=406620656#Maven4.0.0GAchecklist-Maven4API

Bukama · 2026-05-09T15:58:49Z

[INFO] -------------------------------------------------
[ERROR] The following builds failed:
[ERROR] *  deploy-attached-sources\pom.xml
[ERROR] *  deploy-default-packaging\pom.xml
[ERROR] *  MDEPLOY-169_deploy-at-end-multithread\pom.xml
[ERROR] *  MDEPLOY-170_deploy-at-end-configperproject\pom.xml
[ERROR] *  MDEPLOY-224_deploy-at-end-only-modules\pom.xml
[ERROR] *  MDEPLOY-225_deploy-at-end-skip-root\pom.xml

edit:

deploy-attached-sources

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT:deploy-file (default-cli) on project test: D:\target-.jar not found.

deploy-default-packaging

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT:deploy-file (default-cli) on project test: D:\lib\test-1.1.jar not found

MDEPLOY-169_deploy-at-end-multithread

Assertion failed:

assert new File( basedir, "module1/target/repo/org/apache/maven/its/mdeploy-169/module1/1.0/module1-1.0.pom" ).exists()
| | |
| D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-169_deploy-at-end-multithread false
D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-169_deploy-at-end-multithread\module1\target\repo\org\apache\maven\its\mdeploy-169\module1\1.0\module1-1.0.pom

[INFO] Installing D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-169_deploy-at-end-multithread\module1\target\consumer-6293687905353999056.pom to D:\Github\Maven\maven-deploy-plugin\target\local-repo\org\apache\maven\its\mdeploy-169\module1\1.0\module1-1.0.pom

MDEPLOY-170_deploy-at-end-configperproject

Assertion failed:

assert new File( basedir, "module1/target/repo/org/apache/maven/its/mdeploy-170/module1/1.0/module1-1.0.pom" ).exists()
| | |
| D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject false
D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject\module1\target\repo\org\apache\maven\its\mdeploy-170\module1\1.0\module1-1.0.pom

[INFO] Installing D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject\module1\target\consumer-1389750655688884827.pom to D:\Github\Maven\maven-deploy-plugin\target\local-repo\org\apache\maven\its\mdeploy-170\module1\1.0\module1-1.0.pom

MDEPLOY-224_deploy-at-end-only-modules

Assertion failed:

assert new File( basedir, "module1/target/repo/org/apache/maven/its/mdeploy-224/module1/1.0/module1-1.0.pom" ).exists()
| | |
| D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-224_deploy-at-end-only-modules false
D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-224_deploy-at-end-only-modules\module1\target\repo\org\apache\maven\its\mdeploy-224\module1\1.0\module1-1.0.pom

[INFO] Installing D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-224_deploy-at-end-only-modules\module1\target\consumer-10985243690833197708.pom to D:\Github\Maven\maven-deploy-plugin\target\local-repo\org\apache\maven\its\mdeploy-224\module1\1.0\module1-1.0.pom

MDEPLOY-225_deploy-at-end-skip-root

Assertion failed:

assert ! new File( basedir, "target/repo" ).exists()
| | | |
| | | true
| | D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-225_deploy-at-end-skip-root
| D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-225_deploy-at-end-skip-root\target\repo
false

[INFO] Installing D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-225_deploy-at-end-skip-root\pom.xml to D:\Github\Maven\maven-deploy-plugin\target\local-repo\org\apache\maven\its\mdeploy-225\parent\1.0\parent-1.0-build.pom

Bukama · 2026-05-09T18:35:03Z

Interesting: The four ITs with JIRA-issueID overwrite deployAtEnd value to true fail. This is the new default in version 4.x of the plugin, but we are testing 3.x so this should not make any difference when choosing the path to deploy.

I still could not figure out why the distributionManagement is ignored for subprojects

<!-- Set in parent of the IT project -->

<distributionManagement>
  <repository>
    <id>it</id>
    <url>file:///${basedir}/target/repo</url>
  </repository>
</distributionManagement>


// All files are deployed there
[INFO] Uploading to it: file:///D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject/target/repo/org/apache/maven/its/mdeploy-170/configperproject/1.0/configperproject-1.0-build.pom

// Even subprojects files
[INFO] Uploading to it: file:///D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject/target/repo/org/apache/maven/its/mdeploy-170/module1/1.0/module1-1.0.pom

The file exists there (See screenshot below), but the verify script checks the target folder inside each subproject

verify-script:

assert new File( basedir, "target/repo/org/apache/maven/its/mdeploy-170/configperproject/1.0/configperproject-1.0.pom" ).exists()
assert new File( basedir, "module1/target/repo/org/apache/maven/its/mdeploy-170/module1/1.0/module1-1.0.pom" ).exists()
assert !( new File( basedir, "module2/target/repo/org/apache/maven/its/mdeploy-170/module2/1.0/module2-1.0.pom" ).exists() )


Assertion failed:

assert new File( basedir, "module1/target/repo/org/apache/maven/its/mdeploy-170/module1/1.0/module1-1.0.pom" ).exists()
| | |
| D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject false
D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject\module1\target\repo\org\apache\maven\its\mdeploy-170\module1\1.0\module1-1.0.pom

The file exists, but in the target repository of the parent

D:\Github\Maven\maven-deploy-plugin\target\it\MDEPLOY-170_deploy-at-end-configperproject\target\repo\org\apache\maven\its\mdeploy-170\module1\1.0

So what has changed here in Maven 4?

Bukama · 2026-06-06T10:23:42Z

Looking at deploy-attached-sources and deploy-default-packaging

Logs are from deploy-attached-sources

Packaging is right into local repository

[DEBUG] isUp2date: false (Destination D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\target\test-1.0-SNAPSHOT.jar not found.)
[INFO] Building jar: D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\target\test-1.0-SNAPSHOT.jar

But deploying does not pick the project path information when using 4.0.0-SNAPSHOT

[INFO] --- deploy:3.1.5-SNAPSHOT:deploy-file (default-cli) @ test ---
[DEBUG] Collector skip mode enabled: versionless (key function GACE)
[DEBUG] Reading file model from org.codehaus.plexus:plexus-xml:3.0.1
[DEBUG] Reading file model from org.codehaus.plexus:plexus-utils:4.0.2
[DEBUG] Reading file model from org.codehaus.plexus:plexus:18
[DEBUG] Reading file model from org.apache.maven.resolver:maven-resolver-util:1.9.27
[DEBUG] Reading file model from org.junit:junit-bom:5.10.2
[DEBUG] Reading file model from org.apache.maven.resolver:maven-resolver:1.9.27
[DEBUG] Reading file model from org.apache.maven.resolver:maven-resolver-api:1.9.27
[DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=332800, ConflictMarker.markTime=56900, ConflictMarker.nodeCount=5, ConflictIdSorter.graphTime=184300, ConflictIdSorter.topsortTime=169300, ConflictIdSorter.conflictIdCount=5, ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2401000, ConflictResolver.conflictItemCount=5, BfDependencyCollector.collectTime=49614500, BfDependencyCollector.transformTime=5093600}
[DEBUG] org.apache.maven.plugins:maven-deploy-plugin:jar:3.1.5-SNAPSHOT
[DEBUG] +- org.codehaus.plexus:plexus-utils:jar:4.0.2 [compile]
[DEBUG] +- org.codehaus.plexus:plexus-xml:jar:3.0.1 [compile]
[DEBUG] \- org.apache.maven.resolver:maven-resolver-util:jar:1.9.27 [compile]
[DEBUG]    \- org.apache.maven.resolver:maven-resolver-api:jar:1.9.27 [compile]
[DEBUG]   Excluded: org.apache.maven.resolver:maven-resolver-util:jar:1.9.27
[DEBUG]   Excluded: org.apache.maven.resolver:maven-resolver-api:jar:1.9.27
[DEBUG] Created new class realm plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT
[DEBUG] Importing foreign packages into class realm plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT
[DEBUG]   Imported:  < maven.api
[DEBUG] Populating class realm plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT
[DEBUG]   Included: org.apache.maven.plugins:maven-deploy-plugin:jar:3.1.5-SNAPSHOT
[DEBUG]   Included: org.codehaus.plexus:plexus-utils:jar:4.0.2
[DEBUG]   Included: org.codehaus.plexus:plexus-xml:jar:3.0.1
[DEBUG] Loading mojo org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT:deploy-file from plugin realm ClassRealm[plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@5bc2b487]
[DEBUG] Configuring mojo execution 'org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT:deploy-file:default-cli' with basic configurator -->
[DEBUG]   (f) file = D:\target\-.jar
[DEBUG]   (f) generatePom = true
[DEBUG]   (f) javadoc = D:\target\--javadoc.jar
[DEBUG]   (f) offline = false
[DEBUG]   (f) pomFile = D:\pom.xml
[DEBUG]   (f) repositoryId = remote-repository
[DEBUG]   (f) retryFailedDeploymentCount = 1
[DEBUG]   (f) session = org.apache.maven.execution.MavenSession@526f6427
[DEBUG]   (f) skip = false
[DEBUG]   (f) sources = D:\target\--sources.jar
[DEBUG]   (f) url = file:///target/repo
[DEBUG] -- end configuration --

and therefor fails.

With Maven 3.9.16 the configuration is correct

[INFO] --- deploy:3.1.5-SNAPSHOT:deploy-file (default-cli) @ test ---
[DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=417500, ConflictMarker.markTime=50900, ConflictMarker.nodeCount=5, ConflictIdSorter.graphTime=224200, ConflictIdSorter.topsortTime=237100, ConflictIdSorter.conflictIdCount=5, ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2037500, ConflictResolver.conflictItemCount=5, DfDependencyCollector.collectTime=54384700, DfDependencyCollector.transformTime=4312800}
[DEBUG] org.apache.maven.plugins:maven-deploy-plugin:jar:3.1.5-SNAPSHOT
[DEBUG]    org.codehaus.plexus:plexus-utils:jar:4.0.2:compile
[DEBUG]    org.codehaus.plexus:plexus-xml:jar:3.0.1:compile
[DEBUG]    org.apache.maven.resolver:maven-resolver-util:jar:1.9.27:compile
[DEBUG]       org.apache.maven.resolver:maven-resolver-api:jar:1.9.27:compile
[DEBUG] Created new class realm plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT
[DEBUG] Importing foreign packages into class realm plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT
[DEBUG]   Imported:  < maven.api
[DEBUG] Populating class realm plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT
[DEBUG]   Included: org.apache.maven.plugins:maven-deploy-plugin:jar:3.1.5-SNAPSHOT
[DEBUG]   Included: org.codehaus.plexus:plexus-utils:jar:4.0.2
[DEBUG]   Included: org.codehaus.plexus:plexus-xml:jar:3.0.1
[DEBUG] Loading mojo org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT:deploy-file from plugin realm ClassRealm[plugin>org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@5bc2b487]
[DEBUG] Configuring mojo execution 'org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT:deploy-file:default-cli' with basic configurator -->
[DEBUG]   (f) file = D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\target\test-1.0-SNAPSHOT.jar
[DEBUG]   (f) generatePom = true
[DEBUG]   (f) javadoc = D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\target\test-1.0-SNAPSHOT-javadoc.jar
[DEBUG]   (f) offline = false
[DEBUG]   (f) pomFile = D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\pom.xml
[DEBUG]   (f) repositoryId = remote-repository
[DEBUG]   (f) retryFailedDeploymentCount = 1
[DEBUG]   (f) session = org.apache.maven.execution.MavenSession@1416cf9f
[DEBUG]   (f) skip = false
[DEBUG]   (f) sources = D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\target\test-1.0-SNAPSHOT-sources.jar
[DEBUG]   (f) url = file://D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources/target/repo

edit:
When you pass a "file" argument to the test, it gets weired

I added -Dfile="D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\test-1.0-SNAPSHOT.jar to the invoker.properties of invoker.goals.2 as this is the file to be deployed.

This results in the following configuration

[DEBUG]   (f) file = D:\Github\Maven\maven-deploy-plugin\target\it\deploy-attached-sources\D:GithubMavenmaven-deploy-plugin

Bukama · 2026-06-06T13:30:03Z

@cstamas Could you please check if those a resolver related?

hboutemy · 2026-06-13T10:33:48Z

the 4 deployAtEnd IT failures should be fixed by #667

hboutemy · 2026-06-13T10:46:26Z

on deploy-attached-sources IT failure, yes, values seem not injected properly
I think this is a bug in maven-invoker-plugin because https://github.com/apache/maven-deploy-plugin/blob/master/src/it/deploy-attached-sources/test.properties interpolation should do the job in Maven 4 as it does in Maven 3

hboutemy · 2026-06-13T15:03:27Z

running mvn -Prun-its clean verify -Dinvoker.test='deploy-default-packaging,deploy-attached-sources' -X
and looking at the invocations of mvn command
shows that both Maven 3 and 4 invoke with the same command, like

[DEBUG] Executing: /bin/sh -c cd '/home/herve/dev/maven/sources/plugins/core/maven-deploy-plugin/target/it/deploy-attached-sources' && '/home/herve/.sdkman/candidates/maven/4.0.0-SNAPSHOT/bin/mvn' '-B' '-X' '-D' 'maven.repo.local=/home/herve/dev/maven/sources/plugins/core/maven-deploy-plugin/target/local-repo' '-s' '/home/herve/dev/maven/sources/plugins/core/maven-deploy-plugin/target/it/interpolated-settings.xml' '-D' 'javadoc=${basedir}/target/${project.artifactId}-${project.version}-javadoc.jar' '-D' 'file=${basedir}/target/${project.artifactId}-${project.version}.jar' '-D' 'sources=${basedir}/target/${project.artifactId}-${project.version}-sources.jar' '-D' 'url=file://${basedir}/target/repo' '-D' 'pomFile=${basedir}/pom.xml' 'org.apache.maven.plugins:maven-deploy-plugin:3.1.5-SNAPSHOT:deploy-file'

it seems it is interpolation of ${basedir} or ${project.artifactId} at command-line level that does not work the same way between Maven 3 and 4
... continuing the analysis...

hboutemy · 2026-06-13T15:18:34Z

ok, issue is easy to reproduce in any project that has a pom.xml:

mvn install:install-file -Dfile='${basedir}/target/${project.artifactId}-${project.version}.jar' -DpomFile='${basedir}/pom.xml'

with Maven 4:

[INFO] --- install:3.1.3:install-file (default-cli) @ test ---
[ERROR] The specified file '/target/-.jar' does not exist

hboutemy mentioned this pull request Jun 13, 2026

update deployAtEnd ITs to match latest 4 behaviour #667

Merged

enable build with Maven 4

f3a642f

hboutemy force-pushed the maven4-enabled branch from 91b17ae to f3a642f Compare June 13, 2026 12:37

work around Maven 4 CLI lack of interpolation

dd96008

Bukama approved these changes Jun 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable build with Maven 4#655

enable build with Maven 4#655
hboutemy wants to merge 2 commits into
maven-deploy-plugin-3.xfrom
maven4-enabled

hboutemy commented Mar 26, 2026

Uh oh!

Bukama commented May 9, 2026 •

edited

Loading

Uh oh!

Bukama commented May 9, 2026

Uh oh!

Bukama commented Jun 6, 2026 •

edited

Loading

Uh oh!

Bukama commented Jun 6, 2026

Uh oh!

hboutemy commented Jun 13, 2026

Uh oh!

hboutemy commented Jun 13, 2026

Uh oh!

hboutemy commented Jun 13, 2026 •

edited

Loading

Uh oh!

hboutemy commented Jun 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hboutemy commented Mar 26, 2026

Uh oh!

Bukama commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bukama commented May 9, 2026

Uh oh!

Bukama commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bukama commented Jun 6, 2026

Uh oh!

hboutemy commented Jun 13, 2026

Uh oh!

hboutemy commented Jun 13, 2026

Uh oh!

hboutemy commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hboutemy commented Jun 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Bukama commented May 9, 2026 •

edited

Loading

Bukama commented Jun 6, 2026 •

edited

Loading

hboutemy commented Jun 13, 2026 •

edited

Loading