Skip to content

Only log dependency classpath when no property/file output is specified #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only log dependency classpath when no property/file output is specified #1551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,14 @@ public class BuildClasspathMojo extends AbstractDependencyFilterMojo implements

/**
* If defined, the name of a property to which the classpath string will be written.
* If neither this nor the outputFile parameter is set, the classpath will be logged at INFO level.
*/
@Parameter(property = "mdep.outputProperty")
private String outputProperty;

/**
* The file to write the classpath string. If undefined, it just prints the classpath as [INFO].
* If defined, the file to which the classpath string will be written.
* If neither this nor the outputProperty parameter is set, the classpath will be logged at INFO level.
*/
@Parameter(property = "mdep.outputFile")
private File outputFile;
Expand Down Expand Up @@ -237,15 +239,18 @@ protected void doExecute() throws MojoExecutionException {
}
}

if (outputFile == null) {
getLog().info("Dependencies classpath:" + System.lineSeparator() + cpString);
} else {
if (outputFile != null) {
if (regenerateFile || !isUpToDate(cpString)) {
storeClasspathFile(cpString, outputFile);
} else {
this.getLog().info("Skipped writing classpath file '" + outputFile + "'. No changes found.");
}
}

if (outputProperty == null && outputFile == null) {
getLog().info("Dependencies classpath:" + System.lineSeparator() + cpString);
}

if (attach) {
attachFile(cpString);
}
Expand Down