docs: identify the project as Apache Maka (Incubating) in both READMEs - #3391
Conversation
The root READMEs still opened as "Maka" with no incubation status and no path from the repository front page to DISCLAIMER-WIP, so the first surface a reader or a release reviewer sees did not identify the project by its podling name. Rename both README titles to Apache Maka (Incubating), carry the standard ASF incubation disclaimer text near the top of each file, and link DISCLAIMER-WIP as the current record of known issues. Add a "Releases and downloads" section ahead of the existing download instructions. It states that no Apache release exists yet, that what is published today is not an ASF release and has not been through an Incubator PMC vote, and that once Apache releases exist the source release published by the ASF is the release while packages built from it and distributed elsewhere are convenience artifacts. The section deliberately does not say which convenience artifacts belong to the first release; that scope is a PPMC and mentor decision. Add the ASF trademark attribution to the license section of each README, using the wording Apache OpenDAL carries in its site footer. Add the `incubator` topic to `.asf.yaml`, extending the repository metadata that #3262 established. The description there already carries the incubating name; the topic list carried `apache` but not `incubator`. Advances #3272. It does not close it: `maka.apache.org`, the npm package page, the GitHub release surfaces, and the announcement remain open, and several of those depend on the undecided first-release scope. Generated-by: Claude Code
019e62d to
3e4ebfd
Compare
jackwener
left a comment
There was a problem hiding this comment.
Automated review of exact head 3e4ebfdfa60dfba8450c835beef7af9e7ea6b4c2.
The current main README still lacks the complete Incubator identification, disclaimer link, source-release/convenience-artifact framing, and trademark attribution. This patch adds those narrowly in both root READMEs and adds the missing incubator repository topic. The English and Chinese wording is internally consistent, links point at tracked policy files, and I found no P0-P2 defect. Required test is green on this exact head.
Merge readiness: not ready yet because repository protection still requires an independent human review. Given that this is ASF governance/branding language, the reviewing human should be a maintainer/PPMC member or mentor who can validate the policy wording, not merely the Markdown mechanics.
|
Thanks for the review. Agreed on merge readiness, and no changes are needed from this pass. Recording the intent behind two wording choices so a policy reviewer can check them quickly:
Leaving this open for a maintainer/PPMC member or mentor to validate the policy language, as you note. Refs #3272 — this PR covers the README identification and repository metadata criteria only; the website work is tracked in #3404. |
hqhq1025
left a comment
There was a problem hiding this comment.
Reviewed exact head 3e4ebfdfa60dfba8450c835beef7af9e7ea6b4c2.
Verdict: not ready to merge.
The primary problem is real and correctly scoped: the repository README must identify the podling as Apache Maka (Incubating), carry the Incubator disclaimer, link the project disclaimer, and expose appropriate ASF trademark attribution. The title, standard disclaimer text, Chinese authoritative-link treatment, trademark line, and incubator topic are all directionally sound.
One distribution-policy blocker remains in the new releases/downloads presentation. The Incubator vote accepted Maka on August 13, 2026, but the README’s /releases/latest target is v0.1.11, published on August 18 as a normal Latest release. Its release page has no Incubator disclaimer, and this PR itself states that no IPMC-approved Apache source release exists. Incubator distribution guidance requires convenience binaries to be built from an IPMC-approved ASF source release, requires GitHub releases to carry the incubation disclaimer, and says pre-incubation releases must be clearly described and tagged as such.
The new section therefore says the current artifact is not an ASF release and then immediately promotes it as the current Desktop download. A README disclaimer does not make an unapproved post-incubation binary a valid convenience artifact.
First principles / Occam: until an approved source release exists or the IPMC explicitly permits an exception, remove the active /releases/latest download recommendation and describe existing artifacts only as historical/non-ASF where that is factually true. The GitHub release surfaces still need their separately tracked remediation, but this README should not direct new users to a known-unapproved Latest artifact.
Verification:
- exact-head CI is green and GitHub reports the PR mergeable;
- the three-file diff is mechanically clean and all relative links resolve;
- live GitHub metadata confirms
v0.1.11is non-prerelease Latest, published August 18, 2026, with no incubation disclaimer; - the Incubator acceptance result is dated August 13, 2026.
Required conclusions:
- Problem definition: correct for repository identification, incomplete for the download surface the patch edits.
- First principles / Occam: not yet; branding and distribution eligibility must agree.
- Optimality: no while the README promotes an artifact it labels unapproved.
- Production code to delete: none.
- Tests to delete or replace: none; this is a policy/content defect, not a test defect.
- Deeper refactor: no.
- Merge readiness: no.
- Residual risk: npm and GitHub release pages remain outstanding under #3272 even after the README is corrected.
Policy references:
The READMEs stated that nothing published so far is an Apache release, then directed users to the floating /releases/latest download on the next line. That target is v0.1.11, published on 2026-08-18 after the Incubator accepted Maka on 2026-08-13, as a non-prerelease Latest with no incubation disclaimer. Incubator distribution guidance requires convenience binaries to be built from an IPMC-approved ASF source release. Until such a release exists, the READMEs recommend no prebuilt download and point at the existing from-source path. The platform support facts and the Windows preview caveat are kept as a single statement in the releases section. Generated-by: Claude Code
|
Pushed Both READMEs no longer recommend a prebuilt download: the The @hqhq1025 re-requested for review. |
hqhq1025
left a comment
There was a problem hiding this comment.
Reviewed exact head 17f013eb788385fa4ef4fdebb67e06e21372576b.
The previous distribution-policy finding is resolved. Both READMEs now stop recommending /releases/latest or any other prebuilt download until an IPMC-approved source release exists, and direct users to the existing source-build path instead. The retained platform statement accurately distinguishes the supported Apple Silicon development target from the unsigned Windows preview.
The PR now cleanly solves its stated problem: the repository front page identifies Apache Maka as incubating, includes the standard disclaimer and DISCLAIMER-WIP link, explains the source-release/convenience-artifact boundary without promoting an ineligible artifact, adds the ASF trademark attribution, and adds the incubator repository topic. The English and Chinese versions remain semantically aligned.
First-principles / Occam assessment: the implementation is narrowly scoped and uses the README as the correct ownership surface for first-contact project and release status. No deeper refactor is needed. No production code or tests should be deleted or replaced.
Verification: git diff --check passed; .asf.yaml parsed successfully with the incubator label present; all referenced relative targets exist; the merge tree showed no conflicts; GitHub reports the PR mergeable; and the required test workflow completed successfully on this exact head, including lint, format, build, release contracts, typecheck, workspace tests, Runtime Host tests, Desktop E2E, Storybook smoke, and installed CLI release validation.
Merge verdict: ready to merge. Remaining remediation of historical GitHub release and npm surfaces is explicitly tracked under #3272 and does not require this README-focused PR to expand its scope.
Summary
The root READMEs opened as "Maka", with no incubation status and no link from the repository front page to
DISCLAIMER-WIP. This applies Incubator branding to the two surfaces whose wording does not depend on the undecided first-release scope.Refs #3272
Apache Maka (Incubating), and each file carries the standard ASF incubation disclaimer text near the top with a link toDISCLAIMER-WIP..github/ASF_SOURCE_RELEASE.mdfrom release: add the ASF source candidate workflow #3269 / feat(release): add ASF source candidate workflow #3278 for the candidate contract and verification path..asf.yamlgains theincubatortopic, extending the metadata chore: add .asf.yaml for ASF infrastructure self-service #3262 established. The description there already carries the incubating name; the topic list carriedapachebut notincubator.Scope: why this is not
Fixes #3272Four of the seven exit criteria in #3272 depend on decisions that are not mine to make, so this PR deliberately stops short of them.
maka.apache.orgserves the reviewed project website rather than 404KEYSand verification instructionsThe README wording states the source-versus-convenience-artifact distinction in general terms and does not assert that npm or Desktop artifacts are part of the first release. That remains a PPMC and mentor decision under #2974.
Prior art
Wording and structure follow Apache OpenDAL. The trademark line is OpenDAL's site-footer sentence with the project name substituted. The source-versus-convenience-artifact framing matches OpenDAL's download page, which states that official releases are provided as source artifacts and keeps verification against
KEYS, GPG, and SHA-512 next to the download links.The Chinese README marks
DISCLAIMER-WIPas authoritative in English rather than translating the disclaimer as a substitute for it.Verification
npm run format— clean, no fixes applied..asf.yamlround-tripped through thestrictyamlcheck from chore: add .asf.yaml for ASF infrastructure self-service #3262 (dirty_load→as_yaml()→dirty_load): prints184 184 OK, so the folded description scalar is unpolluted, and the parsed label list contains the newincubatortopic.gh api repos/apache/makathat the live description already carries the incubating name and thatincubatoris genuinely absent from the current topics.scripts/are release-packaging code andasf-source-release.test.mjsfixtures that write their ownREADME.md..asf.yaml; none of those suites cover them..asf.yamllabel reconciliation itself can only be verified after merge, when asfyaml processes the change.AI use
Select exactly one:
Tool(s) and scope: Claude Code drafted the README changes, the
.asf.yamltopic, this description, and ran the verification above. The human contributor reviews the final diff and owns the decision to submit it. The commit carries aGenerated-by: Claude Codetrailer.Checklist
.asf.yamland were not runDoes this PR entail a change in behavior?