Migrate log4j-iostreams to use JUnit 5 APIs and compatible helper classes - #3248
Closed
jcoglan wants to merge 2 commits into
Closed
Migrate log4j-iostreams to use JUnit 5 APIs and compatible helper classes#3248jcoglan wants to merge 2 commits into
jcoglan wants to merge 2 commits into
Conversation
jvz
approved these changes
Dec 3, 2024
Contributor
Generated by gradle/develocity-actions |
AlbaHerrerias
force-pushed
the
junit5-iostreams
branch
from
December 11, 2024 16:22
96c8bbf to
6a9af6a
Compare
This was referenced Aug 28, 2026
Contributor
|
suppressed by #4261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in log4j-iostreams.
These changes are mostly straightforward replacements of the JUnit 4 annotations with JUnit 5 ones. The only thing I was unsure about is that I had to add constructors to all the test classes to accept the
LoggerContextargument -- I was wondering if there's a way of just doing this in the abstract classes and having all their children just work without this extra boilerplate.Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory