[BugFix] Update parallelgroup cache when entrance instance goes offline (#5407) - #5478
Open
zhang-arvin wants to merge 1 commit into
Open
[BugFix] Update parallelgroup cache when entrance instance goes offline (#5407)#5478zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When an entrance instance goes offline (via
/markoffline) or comes back online, the cached per-user parallel groups are not refreshed, so jobs keep being routed with concurrency recalculated from a stale entrance count.This PR wires cache refresh into the offline/online transitions:
EntranceGroupFactorynow records each cached group'screator/user/engineTypekey and exposesrefreshAllGroups(), which re-queries the user configuration and recomputesmaxRunningJobswith the latestgetRunningEntranceNumber().EntranceUserParallelOrchestratorPluginexposesinvalidateCache()to drop the 30-minuteconfigCacheentries.EntranceLabelRestfulApi(/markofflineand/backonline) triggers both refreshes after theRouteLabelupdate.EntranceOrchestrationFactorygets ainvalidateUserParallelPluginCache()entry point (Scala 2.11-safe companion class for Java callers).Closes #5407