[KYUUBI #7435][SERVER] Honor server-level kyuubi.server.info.provider in getInfo#7519
Open
Sunwoo-Shin wants to merge 1 commit into
Open
[KYUUBI #7435][SERVER] Honor server-level kyuubi.server.info.provider in getInfo#7519Sunwoo-Shin wants to merge 1 commit into
Sunwoo-Shin wants to merge 1 commit into
Conversation
ruanwenjun
reviewed
Jun 19, 2026
Comment on lines
+301
to
+306
| // SERVER_INFO_PROVIDER is `.serverOnly`, so KyuubiConf.getUserDefaults strips it from | ||
| // sessionConf. Unless the client set it explicitly for this session, fall back to the | ||
| // server-level conf so the operator's kyuubi-defaults.conf setting is honored. | ||
| val provider = sessionConf.getOption(SERVER_INFO_PROVIDER.key) | ||
| .getOrElse(sessionManager.getConf.get(SERVER_INFO_PROVIDER)) | ||
| provider match { |
Member
There was a problem hiding this comment.
Would removing serverOnly from SERVER_INFO_PROVIDER be sufficient?
Author
There was a problem hiding this comment.
Agreed — cleaner. kyuubi.server.info.provider is only consumed by KyuubiSessionImpl#getInfo, never by the engine, so dropping serverOnly is safe.
Reverted the getInfo change, removed the flag, and added KyuubiServerInfoProviderSuite.
…ovider in getInfo kyuubi.server.info.provider is `.serverOnly`, so KyuubiConf.getUserDefaults strips it from the per-session conf and KyuubiSessionImpl#getInfo always saw the default ENGINE, ignoring the operator's kyuubi-defaults.conf. The provider is only read on the server frontend, never on the engine, so drop the serverOnly flag and let the server-level value flow into the session conf.
Sunwoo-Shin
force-pushed
the
kyuubi-7435-honor-server-info-provider
branch
from
02302d2 to
81db479
Compare
ruanwenjun
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Closes #7435.
kyuubi.server.info.providerwas declared.serverOnly, soKyuubiConf#getUserDefaultsstripped it from the per-session conf thatKyuubiSessionManager#openSessionbuilds. As a resultKyuubiSessionImpl#getInforead it throughsessionConf.get(SERVER_INFO_PROVIDER), which never saw the server-level value and always returned the hard-coded defaultENGINE. Settingkyuubi.server.info.provider=SERVERinkyuubi-defaults.confwas therefore silently ignored, and everyGetInforequest waited for the engine to launch and forwarded to it instead of being answered by the server directly.SERVER_INFO_PROVIDERis only read on the server frontend (KyuubiSessionImpl#getInfo); the engine never reads it. Dropping theserverOnlyflag lets the server-level value flow into the session conf sogetInfohonors it, while an explicit per-session value still wins as before.Affected versions: 1.11.1.
How was this patch tested?
Added
KyuubiServerInfoProviderSuite, which boots a server withkyuubi.server.info.provider=SERVERset only at the server level (no per-session override) and assertsGetInfo(CLI_DBMS_NAME)returnsApache Kyuubi. Before the fix it returns the engine name (Spark SQL).Was this patch authored or co-authored using generative AI tooling?
Assisted-by: Claude:claude-opus-4-8