perf(test): poll is_compacting instead of a fixed sleep in replication test

[ishita-0301]

What this does

TestReplicationShareCheckpoint runs COMPACT and then blindly
time.Sleep(time.Second) before starting the replicas. That is slower
than necessary and potentially flaky — on a loaded CI runner one second
may not be enough for the manual compaction to finish, so the test can
proceed while compaction is still running.

This replaces the fixed sleep with the same is_compacting poll already
used elsewhere in the same file (TestReplicationWithHole), returning as
soon as compaction completes:

require.Eventually(t, func() bool {
    return util.FindInfoEntry(masterClient, "is_compacting") == "no"
}, 10*time.Second, 100*time.Millisecond)

Related

Part of #3524, addresses #3527.

Note on testing

I was not able to run the full Go integration suite locally for this
change; it mirrors an existing, already-tested pattern in the same file
rather than introducing new behavior. Happy to adjust if maintainers
prefer a different approach.

[Copilot]

Pull request overview

This PR improves the stability and runtime of the Go replication integration test suite by removing a fixed time.Sleep(1 * time.Second) after triggering manual compaction and instead waiting deterministically for compaction to finish via the is_compacting INFO field (matching an existing pattern already used in the same file).

Changes:

• Replace a fixed sleep in TestReplicationShareCheckpoint with require.Eventually polling on is_compacting == "no".
• Reduce potential test flakiness on slow/loaded CI runners while also avoiding unnecessary waiting when compaction completes quickly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jihuayu]

Hi @ishita-0301. If you can't run the tests locally, you can use the GitHub Actions workflow in your repository: https://github.com/ishita-0301/kvrocks/actions to make sure all tests are passing.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud