perf(tests): shorten list blocking timeout cases#3539
Merged
Conversation
Contributor
Author
|
before: after: from 57s to 44s |
Contributor
Author
|
before: from 57s to 44s |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the runtime of the Go list unit test suite by shortening blocking-command timeout cases, addressing the “list test cost 49s” motivation from issue #3529.
Changes:
- Introduces a shared short blocking timeout constant for list blocking-timeout cases.
- Updates BLPOP/BRPOP and BLMPOP timeout-only test cases to use the shorter timeout value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jihuayu
reviewed
Jun 29, 2026
Assisted-by: Codex/GPT-5
Contributor
Author
|
@jihuayu coverage failed, but i only modify go code |
PragmaTwice
approved these changes
Jul 13, 2026
jihuayu
enabled auto-merge (squash)
July 14, 2026 07:43
Member
Don't worry! It doesn't block. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3529
Assisted-by: Codex/GPT-5