feat(namespace): support namespaces and numbered databases in cluster mode#3500
feat(namespace): support namespaces and numbered databases in cluster mode#3500Abhinav2656 wants to merge 1 commit into
Conversation
PragmaTwice
left a comment
There was a problem hiding this comment.
Thanks for the contribution, but simply dropping these checks doesn't actually make namespaces work in cluster mode.
|
Understood. I see now that removing the restrictions only exposes the lack of cluster-aware namespace routing and replication underneath. To ensure I build this correctly, could you point me toward the specific areas in the cluster topology or replication logic that need to be adapted to fully support namespace propagation? |
|
Hi @Abhinav2656. Thank you for your PR. This is a fairly large project. Slot migration/cleanup still only handles |
|
Hey @jihuayu, thanks for reviewing the PR and for the opportunity! I’m really excited to tackle a project of this scale. You raise a crucial point regarding the default namespace limitations and the need for proper tenant isolation across slot mappings. To ensure we get the architecture right, I’m going to put together a detailed proposal/blueprint outlining how we handle these boundaries during migration. I'll share it here for your feedback first, and once we're completely aligned on the design, I'll move to the implementation. |
You can submit proposals in discussions. We will talk in it. |
Resolves: #3231
What this PR does / why we need it:
This PR removes the restrictions that previously prevented the use of multiple namespaces and numbered databases when cluster mode is enabled.
Specifically, it:
kErrClusterModeEnabledrejection logic insrc/server/namespace.ccto allow namespace creation and modification under cluster mode.src/config/config.ccthat forced a failure when bothcluster_enabledand namespace tokens/databases were present.Brief test explanation:
unit/namespace(go test ./unit/namespace ...) under thetests/gocasesuite.Please let me know if any architectural adjustments are required. I am fully open to your review and stand ready to iterate on this logic as needed.