KNOX-3249: Integrate new yarn scheduler-ui into KNOX homepage#1178
KNOX-3249: Integrate new yarn scheduler-ui into KNOX homepage#1178Hean-Chhinling wants to merge 8 commits intoapache:masterfrom
Conversation
|
Will change the Service Name from "YARNSUI" into "YARN-SCHEDULER-UI" |
|
Can we please add comments to the route, rule and filter entries? What is the purpose of them? |
Sure, I will add some comments for non-trivial rules |
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit 2f8871e. ♻️ This comment has been updated with latest results. |
gateway-service-definitions/src/main/resources/services/yarn-scheduler-ui/1.0.0/service.xml
Outdated
Show resolved
Hide resolved
...a/org/apache/knox/gateway/topology/discovery/cm/model/yarn/YarnSUIServiceModelGenerator.java
Outdated
Show resolved
Hide resolved
gateway-discovery-ambari/src/main/resources/ambari-service-discovery-url-mappings.xml
Outdated
Show resolved
Hide resolved
…nd remove ambari support
moresandeep
left a comment
There was a problem hiding this comment.
@Hean-Chhinling the rules look great, there are a few changes that I suggest you do and this should be ready to go.
Thank you for your contribution to Knox.
...a/org/apache/knox/gateway/topology/discovery/cm/model/yarn/YarnSUIServiceModelGenerator.java
Outdated
Show resolved
Hide resolved
gateway-service-definitions/src/main/resources/services/yarn-scheduler-ui/1.0.0/rewrite.xml
Show resolved
Hide resolved
gateway-service-definitions/src/main/resources/services/yarn-scheduler-ui/1.0.0/service.xml
Outdated
Show resolved
Hide resolved
Thanks @moresandeep for the review! Please kindly review on give your thoughts. I am in the process of spinning up a cluster and test in YARN HA. |
|
I tested in YARN HA environment with:
They work as expected without any problems and in the cdp-proxy.xml it has two hosts same as YARN UI2: When you get time, may I ask for your review again @moresandeep? |
moresandeep
left a comment
There was a problem hiding this comment.
Looks good, thank you for your contribution @Hean-Chhinling! Let's wait for all the checks to pass before committing.
Thanks! |
(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
KNOX-3249 - Integrate new scheduler-ui into YARN
What changes were proposed in this pull request?
Adding the new YARN Scheduler-UI at Knox Homepage. So that it stays behind knox proxy when navigate to Scheduler-UI via Knox homepage.
https://{knox-gateway}:8443/gateway/cdp-proxy/yarn-scheduler-ui/

How was this patch tested?
Manual testing verified that the Scheduler-UI works as expected behind Knox-proxy by adding/deleting queues.
Integration Tests
(Please add or update integration tests
.github/workflows/testsfor the feature you are adding. If no unit test is added, please explain why. Check out.github/workflows/tests/README.mdfor instructions)UI changes
New YARN Scheduler UI will appear at the KNOX Homepage: