[client] Do not close channel when stdin is not a terminal - #2926
Open
holgerfriedrich wants to merge 1 commit into
Open
holgerfriedrich wants to merge 1 commit into
holgerfriedrich wants to merge 1 commit into
Conversation
This allows scripts to run a console command and get the full command output. Closing with Strg-D as intended by KARAF-5995 should still be possible.
jbonofre
self-requested a review
September 20, 2026 07:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows scripts to run a console command and get the full command output. Closing with Strg-D as intended by KARAF-5995 should still be possible.
Background:
bin/client -u karaf -p karaf "shell:info" < /dev/nullprints only "Closed" and exits 1 - same in scripts, pipes, CI and cron, and with-f. The stdin watcher (KARAF-5995, ctrl-d aborts a command) hits EOF at once and closes thechannel. It now starts only when stdin is a terminal.As a new method was
Console.isTerminal()was recently introduced in JDK22 and used if available.This issue was found while debugging #2925 with AI support.