KAFKA-20901: Enforce cordoned log directories configured with relative paths - #23241
Open
majialoong wants to merge 1 commit into
Open
KAFKA-20901: Enforce cordoned log directories configured with relative paths#23241majialoong wants to merge 1 commit into
majialoong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka allows
log.dirsto be configured with relative paths, butcordoned.log.dirswas validated and applied using the original configuration strings, whereasLogManagerconverts log directories to absolute paths and uses those paths for directory ID lookups.As a result, configuring
cordoned.log.dirswith the absolute path reported byDescribeLogDirswas rejected whenlog.dirscontained the equivalent relative path. Using the relative path passed validation, but it did not match the absolute path used internally, so the directory was not reported as cordoned to the controller.This change consistently uses absolute paths when validating and applying
cordoned.log.dirs, including during dynamic reconfiguration and broker heartbeat propagation.