KAFKA-18573: Close verification key resolver in BrokerJwtValidator#22759
Open
FrankYang0529 wants to merge 1 commit into
Open
KAFKA-18573: Close verification key resolver in BrokerJwtValidator#22759FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
fe64910 to
7ee4076
Compare
Signed-off-by: PoAn Yang <payang@apache.org>
7ee4076 to
72f3beb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
BrokerJwtValidator#configureobtains aCloseableVerificationKeyResolverfromVerificationKeyResolverFactory.get()but never closes it, so the JWKSrefresh thread of
RefreshingHttpsJwksVerificationKeyResolverleaks.How
BrokerJwtValidatorconfigures it through the ref-counting wrapper, and releases it in
close().code that supplied it.
VerificationKeyResolverFactorycreate()no longer configures the resolver; initialization isdriven by the wrapper's
configure().RefCountingVerificationKeyResolverremoves its cache entry whenthe last reference is closed, so a subsequent
get()with the sameconfiguration builds a fresh resolver instead of returning the closed
one.