test: cover subscription state validation paths#22757
Open
amirdeljouyi wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added focused regression coverage for offset reset and validation retry behavior. I also tightened the existing truncation tests with assertions for the string description.
Impact on coverage:
maybeSeekUnvalidatedreset guards and the validation retry pathsWhy:
These checks make sure partitions only become eligible for validation/reset at the right time and that truncation details stay visible when they are reported.
I hope you find these tests useful. 😄 Please let me know if you have any questions or concerns.
Thanks,