Skip to content

KAFKA-20761: Add client logs for consumer group configs defined on the broker#22749

Open
suzhiking wants to merge 5 commits into
apache:trunkfrom
suzhiking:kjc-6985-hb-config-logs
Open

KAFKA-20761: Add client logs for consumer group configs defined on the broker#22749
suzhiking wants to merge 5 commits into
apache:trunkfrom
suzhiking:kjc-6985-hb-config-logs

Conversation

@suzhiking

@suzhiking suzhiking commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Inspired by #22730.
heartbeat.internal.ms for async/shared consumer has been migrated
from client to broker side after KIP 848/932. It should be logged on
client-side for better visibility.

Reviewers: Lianet Magrans lmagrans@confluent.io

@github-actions github-actions Bot added triage PRs from the community consumer clients small Small PRs labels Jul 3, 2026
@suzhiking suzhiking marked this pull request as ready for review July 3, 2026 19:05
@lianetm lianetm added ci-approved and removed triage PRs from the community labels Jul 3, 2026

@lianetm lianetm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@suzhiking suzhiking requested a review from lianetm July 3, 2026 20:44
// The heartbeat interval is a group config owned by the broker, so log it when it changes to give
// visibility into the value the coordinator is applying (it is not derivable from client config).
if (heartbeatIntervalMs != previousHeartbeatIntervalMs) {
logger.info("Received heartbeat interval {}ms from the group coordinator", heartbeatIntervalMs);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we include the member id in the log? ("Member {} received hb...", memberId). It helps troubleshoot issues in a group (many logs in this hbMgr/membershipMgr area include it in a smiliar way)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just pushed update, thanks!

@suzhiking suzhiking requested a review from lianetm July 6, 2026 16:04

@lianetm lianetm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants