MINOR: Relax conditions to reduce rebalances with the classic consumer#22705
MINOR: Relax conditions to reduce rebalances with the classic consumer#22705ezhou413 wants to merge 1 commit into
Conversation
| private final Set<String> knownRacks; | ||
| private final boolean hasUnknownReplica; |
There was a problem hiding this comment.
is a boolean enough or do we need to know the nodes that are down? E.g, what about there is a rack change (need to rebalance), at the same time that a replica is down?
Seems safer to be explicit about what we will tolerate and not rebalance. We have "known replicas" (with their racks, like the line above but wonder if we need to track a Map<replicaId, rack> instead), and "unknown replicas" (replicaIds that are down, have no host/rack). Then we can only safely tolerate a rack missing in one of them but present in the other for the same replica ID (that would be exactly the condition we want and nothing more: a replica X that either has the same racks it had before, or it's down). Makes sense?
|
Fixed in #22768 |
Delete this text and replace it with a detailed description of your
change. The PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload
images, or include other supplemental information that should not be
part of the eventual commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy
(including rationale) for the proposed change. Unit and/or integration
tests are expected for any behavior change and system tests should be
considered for larger changes.
Reviewers: Lianet Magrans lmagrans@confluent.io