Repository navigation
test: fix flaky batchJMS_TESTS startup race - #6850
Open
rebelwithoutacause wants to merge 1 commit into
Open
rebelwithoutacause wants to merge 1 commit into
rebelwithoutacause wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes an intermittent failure in the
batchJMS_TESTSbatch test.The JSR223 consumer script in
bin/testfiles/JMS_TESTS.jmxnow starts the JMS connection before it creates the message consumer and registers its listener. Before this change, the connection was started after the consumer and listener were set up.The only file changed is
bin/testfiles/JMS_TESTS.jmx.Motivation and Context
In the original order, the request message could already be waiting in the queue when the consumer was created, especially on slower CI runners. ActiveMQ then delivered it to the connection before it was started and logged a warning:
The message was still processed and all JMS samples completed successfully. The batch test failed anyway, because it requires the generated log to be empty.
Related CI failure (macOS / JDK 17 job,
:src:dist-check:batchJMS_TESTS):https://github.com/apache/jmeter/actions/runs/41797884332
How Has This Been Tested?
./gradlew :src:dist-check:batchJMS_TESTSlocally on Windows with JDK 21. The test passed: all 27 samples completed with 0 errors.JMS_TESTS.logwas empty.git diff --checkpassed.The failure is timing-dependent and was seen on the macOS / JDK 17 CI job, so the local Windows run cannot prove the race is gone. Upstream CI still needs to confirm the fix on the affected macOS / JDK 17 job.
Screenshots (if appropriate):
Not applicable.
Types of changes
Checklist:
🤖 Generated with Claude Code