Don't fail XML save when sample data contains illegal XML characters - #6767
Open
kalayciburak wants to merge 1 commit into
Open
kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
Woodstox rejects NUL and C0 controls by default. Replace them so JTL recording and JMX save keep working after the xmlpull migration. Closes apache#6761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configure the Woodstox
XMLOutputFactoryused byJMeterStaxDriverto replace characters that are illegal in XML 1.0 (NUL and other C0 controls) instead of aborting the write.After the xmlpull to Woodstox migration, saving a JTL sample or a JMX test plan that contains those characters throws
WstxIOException(Invalid null character/Invalid white space character). Binary request bodies recorded from browsers (for example Mozilla telemetry) hit this path.Motivation and Context
Fixes #6761
Woodstox's default
InvalidCharHandler.FailingHandlerrejects those characters. Replacing them with a space keeps the XML well-formed so recording and test-plan save succeed, matching the previous xmlpull behaviour of not failing the save.How Has This Been Tested?
./gradlew :src:core:test --tests org.apache.jmeter.save.SaveServiceInvalidXmlCharTest— 2/0./gradlew :src:core:test --tests org.apache.jmeter.save.SaveServiceInvalidXmlCharTest --tests org.apache.jmeter.save.TestCSVSaveService— 13/0./gradlew :src:core:style— BUILD SUCCESSFULTypes of changes
Checklist: