Repository navigation
[To dev/1.3] Fix SessionPool result-set cleanup and shutdown handling (#19288) - #19292
Merged
Merged
Conversation
* Fix pooled session and result-set cleanup * Serialize table session lifecycle operations * Make close concurrency test deterministic (cherry picked from commit 8b7cf27)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.3 #19292 +/- ##
=============================================
- Coverage 47.52% 47.51% -0.02%
- Complexity 221 223 +2
=============================================
Files 3678 3678
Lines 252282 252300 +18
Branches 31394 31398 +4
=============================================
- Hits 119906 119877 -29
- Misses 132376 132423 +47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Backports the shared tree-model
SessionPoolfixes from #19288 (8b7cf27) todev/1.3.For example, exhausting result set A returns its session to the pool. If query B reuses that session, calling
A.close()again previously removed B's occupied entry and returned its connection while B was still using it. The wrapper now detaches its session before reuse, so repeated or concurrent closes release it only once.Failed result-set cleanup now closes the broken physical session before creating a replacement. Operations returning after pool shutdown close their connections, and failures after shutdown do not create replacements.
Compatibility adaptations:
putBackremains private.Validation:
iotdb-client/session.mvn clean test -pl iotdb-client/session -am -Dtest=SessionPoolCloseTest,SessionPoolTest,SessionPoolExceptionTest -Dsurefire.failIfNoSpecifiedTests=false: 110 tests passed, 0 failures, 0 errors, 0 skipped on JDK 17.Target base: 14d9c0c.