Repository navigation
[dev/1.3] Fix JDBC batch failure reporting - #19261
Merged
Merged
Conversation
* Fix JDBC batch failure status handling * Fix invalid integration test fixtures exposed by batch error reporting * Fix legacy table IT setup data (cherry picked from commit 594a237)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Backport the applicable parts of #19245 (594a237) to
dev/1.3.Batch statements whose execution returns an error status can currently be reported as successful because only thrown exceptions clear the success flag. Check every execution result so JDBC receives the per-statement failures and raises
BatchUpdateException, while keeping success and redirection statuses accepted.Also retain the two BLOB fixture corrections from the original commit in
IoTDBReplaceFunctionITandIoTDBSubStringFunctionIT. The table-model database synchronization change and five tests absent fromdev/1.3are omitted during conflict resolution.Validation:
mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode,integration-test.git diff --cached --checkbefore committing.