Repository navigation
Conversation
|
Round 1 review: inspected the complete task diff and relevant Pipe test and production context. No actionable issues were found, and no fixes were needed. Verification: Remote CI was not awaited; some checks were queued or in progress. |
|
Review round summary for head 4917894: no actionable findings in the full PR diff. This follow-up gives integration-test DataNode shutdown hooks up to 60 seconds to finish while preserving the generic node stop default. It routes testStoppedDataNode and the status-sensitive SessionPoolIT shutdowns through the environment shutdown API. Validation: four focused integration tests passed in the local clean-reactor run, and git diff --check passed. No additional tests were run on the PR worktree; CI for this head has not reported results yet. Reviewed base: 6e7448d. Reviewed and final local SHA: 4917894. Confirmed remote PR and source branch SHA: 4917894. Update complete; PR is open. |
…-master # Conflicts: # integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java # integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java
Several Pipe concurrency tests used short, fixed waits that could expire before asynchronous work reached the state under test. This change makes waits observe latch or worker state, prevents cleanup from being skipped after assertion failures, and keeps the missed-notification test's polling interval beyond its test timeout.
It also bounds the total AirGap queue wait and makes parser-memory reservation cleanup run even when executor shutdown fails.
Validation:
git diff --checkpassed.The Maven run compiled all DataNode test sources; 61 reactor goals were restored from the local build cache.