Skip to content

[Test] Stabilize Pipe concurrency tests - #19143

Open
Caideyipi wants to merge 4 commits into
apache:masterfrom
Caideyipi:codex/fix-pipesink-latch-timeout-followup
Open

Caideyipi wants to merge 4 commits into
apache:masterfrom
Caideyipi:codex/fix-pipesink-latch-timeout-followup

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Several Pipe concurrency tests used short, fixed waits that could expire before asynchronous work reached the state under test. This change makes waits observe latch or worker state, prevents cleanup from being skipped after assertion failures, and keeps the missed-notification test's polling interval beyond its test timeout.

It also bounds the total AirGap queue wait and makes parser-memory reservation cleanup run even when executor shutdown fails.

Validation:

  • Focused DataNode reactor run: 88 tests passed across 8 affected test classes.
  • 17 tests across 3 other modified classes passed in the preceding validation.
  • Spotless and git diff --check passed.

The Maven run compiled all DataNode test sources; 61 reactor goals were restored from the local build cache.

@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Round 1 review: inspected the complete task diff and relevant Pipe test and production context. No actionable issues were found, and no fixes were needed.

Verification: git diff --check and Spotless passed. The focused DataNode reactor run passed 88 tests across eight modified test classes; 17 tests across three other modified test classes passed in prior validation. The DataNode test sources compiled; 61 goals were restored from the local build cache.

Remote CI was not awaited; some checks were queued or in progress.

@Caideyipi
Caideyipi marked this pull request as draft November 16, 2026 04:01
@Caideyipi
Caideyipi marked this pull request as ready for review November 16, 2026 04:07
@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Review round summary for head 4917894: no actionable findings in the full PR diff.

This follow-up gives integration-test DataNode shutdown hooks up to 60 seconds to finish while preserving the generic node stop default. It routes testStoppedDataNode and the status-sensitive SessionPoolIT shutdowns through the environment shutdown API.

Validation: four focused integration tests passed in the local clean-reactor run, and git diff --check passed. No additional tests were run on the PR worktree; CI for this head has not reported results yet.

Reviewed base: 6e7448d. Reviewed and final local SHA: 4917894. Confirmed remote PR and source branch SHA: 4917894. Update complete; PR is open.

@Caideyipi
Caideyipi marked this pull request as draft November 16, 2026 04:22
…-master

# Conflicts:
#	integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java
#	integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java
@Caideyipi
Caideyipi marked this pull request as ready for review November 16, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant