Fix pipe idempotent IT setup synchronization - #18363
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the remaining setup race in
IoTDBPipeIdempotentITafter #18316.The pipe applies configuration events asynchronously. Waiting for the initial database snapshot does not guarantee that the statements in
beforeSqlList(for example,CREATE USER) have reached the receiver. The test can therefore create the receiver-side idempotent conflict too early and fail with errors such asUser newUser does not exist.Queue a database marker after the setup statements and wait until it is visible on the receiver before creating the conflict. Queue a second marker after the conflict to verify that the pipe continues processing subsequent events.
Tests
mvn spotless:check -pl integration-test -P with-integration-testsmvn '-Ddevelocity.off=true' -P 'with-integration-tests,MultiClusterIT2DualTableManualEnhanced' -pl integration-test -am '-DskipUTs' '-DintegrationTest.forkCount=1' '-Dit.test=IoTDBPipeIdempotentIT#testTableAlterUserIdempotent3' '-Dfailsafe.failIfNoSpecifiedTests=false' verifyThis PR has: