Fix SHOW QUERIES and KILL QUERY privilege filtering - #18359
Open
shuwenwei wants to merge 4 commits into
Open
Conversation
shuwenwei
marked this pull request as ready for review
July 30, 2026 03:35
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18359 +/- ##
============================================
- Coverage 43.40% 43.39% -0.01%
Complexity 374 374
============================================
Files 5366 5366
Lines 382885 382885
Branches 49796 49796
============================================
- Hits 166187 166171 -16
- Misses 216698 216714 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
SHOW QUERIESresults to the current user when the user does not satisfy theMAINTAINauthorization check.KILL QUERYto the current user's queries under the same condition.SYSTEMprivilege, which contains the deprecatedMAINTAINprivilege, to view and kill queries from all users.IoTDBShowQueriesITandIoTDBKillQueryITwith queries that remain active across Session fetches.Root cause
TreeAccessCheckVisitor.visitShowQueriesandvisitKillQuerysetallowedUsernamewhen theMAINTAINauthorization check succeeded instead of when it failed. As a result, an unprivileged user could see or kill other users' queries, while a privileged user could be unnecessarily restricted.Impact
Tree-model
SHOW QUERIESandKILL QUERYnow apply the intended visibility and control rules while retaining the existingMAINTAINauthorization check.Validation
SYSTEM; the tests do not grant deprecatedMAINTAINdirectly.