Skip to content

[Pipe] Fix historical TsFile schema recovery race - #18314

Open
Caideyipi wants to merge 2 commits into
masterfrom
fix/pipe-historical-schema-race
Open

[Pipe] Fix historical TsFile schema recovery race#18314
Caideyipi wants to merge 2 commits into
masterfrom
fix/pipe-historical-schema-race

Clarify load schema creation and lock lifecycle

4ee2fbe
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 30, 2026 in 3m 4s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 480 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 134 to 64, Complexity from 34 to 14, Nesting Level from 4 to 2, Number of Variables from 8 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuaeUIpiSWRJFzH_n&open=AZ-xuaeUIpiSWRJFzH_n&pullRequest=18314

Check failure on line 111 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/security/AllowAllAccessControl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuaQZIpiSWRJFzH_k&open=AZ-xuaQZIpiSWRJFzH_k&pullRequest=18314

Check warning on line 478 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 130). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAF&open=AZ-xuao9IpiSWRJFzIAF&pullRequest=18314

Check failure on line 1376 in iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xua1mIpiSWRJFzIAc&open=AZ-xua1mIpiSWRJFzIAc&pullRequest=18314

Check warning on line 474 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 125). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAE&open=AZ-xuao9IpiSWRJFzIAE&pullRequest=18314

Check warning on line 2225 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/AlignedTVList.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 138 to 64, Complexity from 36 to 14, Nesting Level from 5 to 2, Number of Variables from 24 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuaikIpiSWRJFzH_u&open=AZ-xuaikIpiSWRJFzH_u&pullRequest=18314

Check warning on line 62 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/audit/DNAuditLogger.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its complexity from 25 to the 20 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuameIpiSWRJFzH_3&open=AZ-xuameIpiSWRJFzH_3&pullRequest=18314

Check warning on line 525 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 132). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAL&open=AZ-xuao9IpiSWRJFzIAL&pullRequest=18314

Check warning on line 464 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 101). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAC&open=AZ-xuao9IpiSWRJFzIAC&pullRequest=18314

Check warning on line 1441 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'sortedTVList' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuZusIpiSWRJFzH_g&open=AZ-xuZusIpiSWRJFzH_g&pullRequest=18314

Check warning on line 1128 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/AlignedTVList.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "long". 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuaikIpiSWRJFzH_r&open=AZ-xuaikIpiSWRJFzH_r&pullRequest=18314

Check warning on line 471 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 126). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAD&open=AZ-xuao9IpiSWRJFzIAD&pullRequest=18314

Check warning on line 3714 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/ClientRPCServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'IllegalStateException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuaZpIpiSWRJFzH_l&open=AZ-xuaZpIpiSWRJFzH_l&pullRequest=18314

Check warning on line 1029 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 108). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuayIIpiSWRJFzIAa&open=AZ-xuayIIpiSWRJFzIAa&pullRequest=18314

Check failure on line 48 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/scheduler/LockQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove usage of generic wildcard type. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuaq3IpiSWRJFzIAT&open=AZ-xuaq3IpiSWRJFzIAT&pullRequest=18314

Check warning on line 1046 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 153). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuayIIpiSWRJFzIAb&open=AZ-xuayIIpiSWRJFzIAb&pullRequest=18314

Check warning on line 554 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 10, expected level should be 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAO&open=AZ-xuao9IpiSWRJFzIAO&pullRequest=18314

Check warning on line 513 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 102). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAJ&open=AZ-xuao9IpiSWRJFzIAJ&pullRequest=18314

Check warning on line 562 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 10, expected level should be 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAQ&open=AZ-xuao9IpiSWRJFzIAQ&pullRequest=18314

Check warning on line 549 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'switch' has incorrect indentation level 8, expected level should be 4. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzIAM&open=AZ-xuao9IpiSWRJFzIAM&pullRequest=18314

Check warning on line 1271 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/AlignedTVList.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,253'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuaikIpiSWRJFzH_v&open=AZ-xuaikIpiSWRJFzH_v&pullRequest=18314

Check warning on line 1379 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'reconcileAlignedTVListRamCost' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuZusIpiSWRJFzH_e&open=AZ-xuZusIpiSWRJFzH_e&pullRequest=18314

Check warning on line 1376 in iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 106 to 64, Complexity from 16 to 14, Nesting Level from 4 to 2, Number of Variables from 13 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xua1mIpiSWRJFzIAd&open=AZ-xua1mIpiSWRJFzIAd&pullRequest=18314

Check warning on line 120 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/audit/PasswordChangeAuditContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof AuthorStatement authorstatement' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xualXIpiSWRJFzH_w&open=AZ-xualXIpiSWRJFzH_w&pullRequest=18314

Check warning on line 508 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/AbstractOperatePipeProcedureV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof AbstractOperatePipeProcedureV2 abstractoperatepipeprocedurev2' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ-xuao9IpiSWRJFzH_-&open=AZ-xuao9IpiSWRJFzH_-&pullRequest=18314
View more details on SonarQubeCloud