Skip to content

[Pipe] Fix omitted legacy tablet compatibility follow-ups#17929

Open
Caideyipi wants to merge 4 commits into
masterfrom
fix-legacy-compat-followup
Open

[Pipe] Fix omitted legacy tablet compatibility follow-ups#17929
Caideyipi wants to merge 4 commits into
masterfrom
fix-legacy-compat-followup

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

This PR cherry-picks follow-up fixes for legacy compatibility that were missed in the previous legacy fix.

It adds legacy 1.3.x tablet batch binary request handling, hardens tablet deserialization validation/error context, and adds coverage for legacy single-column/truncated tablet cases.

Tests:

  • Attempted .\mvnw.cmd -pl iotdb-core/datanode -Dtest=PipeDataNodeThriftRequestTest -DskipITs -Dspotless.check.skip=true test, but single-module compile missed reactor dependencies.
  • Attempted .\mvnw.cmd -pl iotdb-core/datanode -am -Dtest=PipeDataNodeThriftRequestTest -DskipITs -Dspotless.check.skip=true -Dsurefire.failIfNoSpecifiedTests=false test, but local generated thrift compile failed because javax.annotation is unavailable.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.2% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.63717% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.04%. Comparing base (aec7dfb) to head (e9f3c85).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../evolvable/request/PipeTransferTabletBatchReq.java 51.72% 28 Missing ⚠️
...db/db/pipe/sink/util/TabletStatementConverter.java 61.70% 18 Missing ⚠️
...ad/evolvable/request/PipeTransferTabletRawReq.java 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #17929   +/-   ##
=========================================
  Coverage     41.04%   41.04%           
  Complexity      318      318           
=========================================
  Files          5252     5252           
  Lines        364388   364474   +86     
  Branches      47096    47115   +19     
=========================================
+ Hits         149551   149604   +53     
- Misses       214837   214870   +33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants