Conversation
Contributor
xiaoyekanren
commented
Jun 26, 2025
- optimized code for sprint-boot-start
- fix dependence conflicts for pom
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to optimize the spring boot starter code and resolve dependency conflicts. Key changes include:
- Updating method calls to use boolean property methods (e.g., isEnable_auto_fetch()).
- Refactoring the IoTDB session properties for better type consistency.
- Adjustments in multiple POM files to update dependency versions and change parent POMs.
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| iotdb-spring-boot-starter/src/main/java/org/apache/iotdb/session/IoTDBSessionPool.java | Updated method calls to use boolean getters and fixed timeout property references. |
| iotdb-spring-boot-starter/src/main/java/org/apache/iotdb/config/IoTDBSessionProperties.java | Refactored property method signatures and fixed a naming issue for the session timeout property. |
| iotdb-spring-boot-starter/pom.xml | Updated spring.version and added the iotdb-version property. |
| examples/pom.xml | Removed unused modules from the examples and updated references. |
| examples/mybatisplus-generator/src/test/java/org/apache/iotdb/ApplicationTest.java | Commented out the contextLoads test, reducing test coverage. |
| examples/mybatisplus-generator/pom.xml | Updated dependency versions and parent POM, though a typo in the version string was introduced. |
| Others | Minor formatting and XML declaration adjustments in mapper and controller files. |
Comments suppressed due to low confidence (1)
examples/mybatisplus-generator/src/test/java/org/apache/iotdb/ApplicationTest.java:34
- The contextLoads test is commented out, which may reduce test coverage; please re-enable it or ensure that another test covers the same functionality.
// @Test
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CritasWang
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.