-
Notifications
You must be signed in to change notification settings - Fork 45
fix: introducing auto-download .so and makefile #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.7.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing this bug.
Ethereal-O
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some issues. I am working on these.
| TOOLS_DIR="$PROJECT_ROOT/tools" | ||
|
|
||
| # Versions | ||
| SUPERVISORD_VERSION="4.2.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version is 0.6.9
|
|
||
| # Download supervisord for different platforms | ||
| # MD5 checksums for supervisord v4.2.5 | ||
| download_supervisord "linux_amd64" "x86_64" "" # Add MD5 if available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct arch is 64-bit
| # Download supervisord for different platforms | ||
| # MD5 checksums for supervisord v4.2.5 | ||
| download_supervisord "linux_amd64" "x86_64" "" # Add MD5 if available | ||
| download_supervisord "linux_arm64" "aarch64" "" # Add MD5 if available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct arch is ARM64
| # MD5 checksums for protoc v21.12 | ||
| download_protoc "linux64" "linux-x86_64" "" # Add MD5 if available | ||
| download_protoc "osxm1" "osx-aarch_64" "" # Add MD5 if available | ||
| download_protoc "win64" "win64" "" # Add MD5 if available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be fail because the file downloaded is named 'proto.exe'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be no need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can not be generated automatically. I am working on this.
New files added:
Modified files: