Skip to content

Conversation

@Pengzna
Copy link

@Pengzna Pengzna commented Nov 8, 2025

New files added:

  1. scripts/download_binaries.sh - Scripts for automatically downloading supervisord and protoc
  2. Makefile - Provides build commands such as make init and make build

Modified files:

  1. build.sh - Added steps for automatically downloading and generating assets
  2. README.md - Updated build instructions
  3. README.zh-CN.md - Updated Chinese build instructions

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. feature New feature labels Nov 8, 2025
Copy link
Contributor

@Ethereal-O Ethereal-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this bug.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 9, 2025
Copy link
Contributor

@Ethereal-O Ethereal-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues. I am working on these.

TOOLS_DIR="$PROJECT_ROOT/tools"

# Versions
SUPERVISORD_VERSION="4.2.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is 0.6.9


# Download supervisord for different platforms
# MD5 checksums for supervisord v4.2.5
download_supervisord "linux_amd64" "x86_64" "" # Add MD5 if available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct arch is 64-bit

# Download supervisord for different platforms
# MD5 checksums for supervisord v4.2.5
download_supervisord "linux_amd64" "x86_64" "" # Add MD5 if available
download_supervisord "linux_arm64" "aarch64" "" # Add MD5 if available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct arch is ARM64

# MD5 checksums for protoc v21.12
download_protoc "linux64" "linux-x86_64" "" # Add MD5 if available
download_protoc "osxm1" "osx-aarch_64" "" # Add MD5 if available
download_protoc "win64" "win64" "" # Add MD5 if available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be fail because the file downloaded is named 'proto.exe'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be no need

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can not be generated automatically. I am working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants