Skip to content

IGNITE-29239 Fix flaky TcpDiscoverySelfTest.testGetEffectiveNodeAddressesFiltersUnresolvedAddressWithoutNpe #13776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wernerdv wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IGNITE-29239 Fix flaky TcpDiscoverySelfTest.testGetEffectiveNodeAddressesFiltersUnresolvedAddressWithoutNpe #13776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b4a89d
IGNITE-29239 Fix flaky TcpDiscoverySelfTest.testGetEffectiveNodeAddre…
wernerdv Oct 30, 2026
38b51b6
cleanup
wernerdv Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,32 +2383,18 @@ public void testGetEffectiveNodeAddressesFiltersUnresolvedAddressWithoutNpe() th

assertNotNull(realNode);

// Wrap real node so that socketAddresses() returns an unresolved InetSocketAddress.
TcpDiscoveryNode nodeWithUnresolvedAddr = new TestTcpDiscoveryNodeWithUnresolvedAddress(realNode);

// Ensure the wrapped node is considered different from the local node by UUID.
assertNotEquals(ignite1.localNode().id(), nodeWithUnresolvedAddr.id());

// Verify test node has at least one unresolved address.
boolean hasUnresolved = false;

for (InetSocketAddress addr : nodeWithUnresolvedAddr.socketAddresses()) {
if (addr.getAddress() == null) {
hasUnresolved = true;

break;
}
}

assertTrue("Test node should have at least one unresolved address", hasUnresolved);
assertTrue("Test node should have at least one unresolved address",
nodeWithUnresolvedAddr.socketAddresses().stream().anyMatch(addr -> addr.getAddress() == null));

// Should not throw NPE; unresolved addresses must be filtered out.
LinkedHashSet<InetSocketAddress> effAddrs = spi1.getEffectiveNodeAddresses(nodeWithUnresolvedAddr, false);

assertNotNull(effAddrs);

for (InetSocketAddress addr : effAddrs)
assertNotNull("Unresolved address (getAddress() == null) should have been filtered out", addr.getAddress());
assertTrue("Unresolved address (getAddress() == null) should have been filtered out",
effAddrs.stream().noneMatch(addr -> addr.getAddress() == null));
}
finally {
stopAllGrids();
Expand Down Expand Up @@ -2984,8 +2970,7 @@ public TestTcpDiscoveryNodeWithUnresolvedAddress(TcpDiscoveryNode delegate) {
@Override public Collection<InetSocketAddress> socketAddresses() {
List<InetSocketAddress> addrs = new ArrayList<>(super.socketAddresses());

// Unresolved address: getAddress() returns null.
addrs.add(new InetSocketAddress("unresolved-host-name-that-does-not-resolve-xyz", 47500));
addrs.add(InetSocketAddress.createUnresolved("unresolved", 47500));

return addrs;
}
Expand Down
Loading