IGNITE-27341 .ΝΕΤ: Introduce task name for compute tasks #12609
Conversation
ptupitsyn
changed the title
| /// <typeparam name="TArg">Argument type.</typeparam> | ||
| /// <typeparam name="TJobRes">Type of job result.</typeparam> | ||
| /// <typeparam name="TRes">Type of final task result.</typeparam> | ||
| TRes Execute<TArg, TJobRes, TRes>(string taskName, IComputeTask<TArg, TJobRes, TRes> task, TArg taskArg); |
There was a problem hiding this comment.
This is different from the Java API, which has only one execute method with a task name:
public <T, R> R execute(String taskName, @Nullable T arg)
Can you please explain the idea here?
There was a problem hiding this comment.
I referred to the methods ExecuteJavaTask() and ExecuteJavaTaskAsync() upon enhancing similar methods for .Net tasks invocation, since the new argument 'taskName' was present in all versions of java task call methods.
The initial idea was to promote task name from .Net task name to Java task. Then I introduced this argument to all .Net task call methods. May be the right place for this change is a different PR.
There was a problem hiding this comment.
I don't think we need to change anything in .NET, especially in the public API. The ticket is about passing correct task name to system views, metrics, and logs. PlatformFullTask#taskName already contains what we need, and the fix in GridTaskProcessor should be enough.
2 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.