IGNITE-28454 C++3.0: Reduce generated files names and paths#7929
Merged
ygerzhedovich merged 4 commits intoapache:mainfrom Apr 6, 2026
Merged
IGNITE-28454 C++3.0: Reduce generated files names and paths#7929ygerzhedovich merged 4 commits intoapache:mainfrom
ygerzhedovich merged 4 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the C++ build tooling to shorten generated file/target names (primarily for Windows path-length constraints) and generalizes the “compile public headers” check to cover all installed public headers across modules.
Changes:
- Switched the public-header compilation check to use a single aggregated header list (via a new
ignite_collect_public_headersCMake macro). - Shortened compile-check build/output paths and generated source/target names (MD5-based).
- Adjusted an internal include in
bytes.hto use a local include path.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/platforms/cpp/tests/package-test/compile_public_headers/CMakeLists.txt | Uses short MD5-based names for generated compile-check sources/targets and includes headers by full installed include path. |
| modules/platforms/cpp/ignite/tuple/CMakeLists.txt | Registers tuple module public headers for the aggregated header compile-check. |
| modules/platforms/cpp/ignite/protocol/CMakeLists.txt | Adds aggregated header registration hook (currently no public headers listed). |
| modules/platforms/cpp/ignite/odbc/CMakeLists.txt | Adds aggregated header registration hook (currently no public headers listed). |
| modules/platforms/cpp/ignite/network/CMakeLists.txt | Adds aggregated header registration hook (currently no public headers listed). |
| modules/platforms/cpp/ignite/common/detail/bytes.h | Makes config.h include local to the detail/ directory. |
| modules/platforms/cpp/ignite/common/CMakeLists.txt | Registers common module public headers for the aggregated header compile-check. |
| modules/platforms/cpp/ignite/client/CMakeLists.txt | Replaces client-only header export with aggregated header registration. |
| modules/platforms/cpp/CMakeLists.txt | Wires in the new macro and initializes IGNITE3_ALL_PUBLIC_HEADERS. |
| modules/platforms/cpp/cmake/ignite_compile_headers.cmake | Consumes IGNITE3_ALL_PUBLIC_HEADERS and shortens the working directory for the header compile-check. |
| modules/platforms/cpp/cmake/ignite_collect_public_headers.cmake | New macro to accumulate installed public headers across modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/platforms/cpp/tests/package-test/compile_public_headers/CMakeLists.txt
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/tests/package-test/compile_public_headers/CMakeLists.txt
Outdated
Show resolved
Hide resolved
added 2 commits
April 3, 2026 18:32
isapego
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28454
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes