Skip to content

IGNITE-28454 C++3.0: Reduce generated files names and paths#7929

Merged
ygerzhedovich merged 4 commits intoapache:mainfrom
gridgain:ignite-28454
Apr 6, 2026
Merged

IGNITE-28454 C++3.0: Reduce generated files names and paths#7929
ygerzhedovich merged 4 commits intoapache:mainfrom
gridgain:ignite-28454

Conversation

@arcolight
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/IGNITE-28454

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the C++ build tooling to shorten generated file/target names (primarily for Windows path-length constraints) and generalizes the “compile public headers” check to cover all installed public headers across modules.

Changes:

  • Switched the public-header compilation check to use a single aggregated header list (via a new ignite_collect_public_headers CMake macro).
  • Shortened compile-check build/output paths and generated source/target names (MD5-based).
  • Adjusted an internal include in bytes.h to use a local include path.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/platforms/cpp/tests/package-test/compile_public_headers/CMakeLists.txt Uses short MD5-based names for generated compile-check sources/targets and includes headers by full installed include path.
modules/platforms/cpp/ignite/tuple/CMakeLists.txt Registers tuple module public headers for the aggregated header compile-check.
modules/platforms/cpp/ignite/protocol/CMakeLists.txt Adds aggregated header registration hook (currently no public headers listed).
modules/platforms/cpp/ignite/odbc/CMakeLists.txt Adds aggregated header registration hook (currently no public headers listed).
modules/platforms/cpp/ignite/network/CMakeLists.txt Adds aggregated header registration hook (currently no public headers listed).
modules/platforms/cpp/ignite/common/detail/bytes.h Makes config.h include local to the detail/ directory.
modules/platforms/cpp/ignite/common/CMakeLists.txt Registers common module public headers for the aggregated header compile-check.
modules/platforms/cpp/ignite/client/CMakeLists.txt Replaces client-only header export with aggregated header registration.
modules/platforms/cpp/CMakeLists.txt Wires in the new macro and initializes IGNITE3_ALL_PUBLIC_HEADERS.
modules/platforms/cpp/cmake/ignite_compile_headers.cmake Consumes IGNITE3_ALL_PUBLIC_HEADERS and shortens the working directory for the header compile-check.
modules/platforms/cpp/cmake/ignite_collect_public_headers.cmake New macro to accumulate installed public headers across modules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ygerzhedovich ygerzhedovich merged commit c91c153 into apache:main Apr 6, 2026
5 checks passed
@ygerzhedovich ygerzhedovich deleted the ignite-28454 branch April 6, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants