fix(bdd): resolve server address and credentials only from env - #3935
Open
chengxilo wants to merge 2 commits into
Open
fix(bdd): resolve server address and credentials only from env#3935chengxilo wants to merge 2 commits into
chengxilo wants to merge 2 commits into
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3935 +/- ##
============================================
- Coverage 83.87% 83.66% -0.21%
Complexity 1358 1358
============================================
Files 1212 1212
Lines 166843 166845 +2
Branches 134306 134432 +126
============================================
- Hits 139937 139598 -339
- Misses 23266 23480 +214
- Partials 3640 3767 +127
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #3883
Rationale
A fallback turns a configuration bug into either a misleading connection error
or, worse, a green run against the wrong server. Tests should be loud when they
are broken.
What changed?
Each suite now reads those values through a required-env helper that aborts when
a variable is unset or empty, and the image no longer carries defaults. The PHP
path moves onto the key names the other seven SDKs already use
(
IGGY_TCP_ADDRESS,IGGY_ROOT_USERNAME,IGGY_ROOT_PASSWORD); the PHP SDKsuite keeps its own defaults, so only the names change there. Two CI steps run
bdd/gooutsiderun-bdd-tests.shand were relying on the removed defaults,one of them with no environment block at all; both now pass the variables
explicitly.
Local Execution
AI Usage
./scripts/run-bdd-tests.shto handle the chores. It's kinda annoying to export some environment variable everytime you want to run the unit tests.