Skip to content

fix(consensus): keep a client's dedup fence across capacity eviction - #3934

Open
numinnex wants to merge 2 commits into
masterfrom
fix_client_table_adverserial_test
Open

fix(consensus): keep a client's dedup fence across capacity eviction#3934
numinnex wants to merge 2 commits into
masterfrom
fix_client_table_adverserial_test

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

No description provided.

@numinnex

Copy link
Copy Markdown
Contributor Author

Merge after #3931

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.02488% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.56%. Comparing base (c0c7493) to head (76460a1).

Files with missing lines Patch % Lines
core/consensus/src/client_table.rs 96.59% 3 Missing and 2 partials ⚠️
core/shard/src/router.rs 62.50% 3 Missing ⚠️
core/server_common/src/consensus_message.rs 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3934      +/-   ##
============================================
- Coverage     83.87%   83.56%   -0.31%     
  Complexity     1358     1358              
============================================
  Files          1212     1212              
  Lines        166843   166741     -102     
  Branches     134306   134329      +23     
============================================
- Hits         139937   139345     -592     
- Misses        23266    23614     +348     
- Partials       3640     3782     +142     
Components Coverage Δ
Rust Core 84.52% <95.02%> (-0.13%) ⬇️
Java SDK 66.67% <ø> (ø)
C# SDK 74.89% <ø> (-1.66%) ⬇️
Python SDK 90.13% <ø> (ø)
PHP SDK 84.48% <ø> (ø)
Node SDK 94.03% <ø> (-1.82%) ⬇️
Go SDK 68.37% <ø> (+0.04%) ⬆️
Files with missing lines Coverage Δ
core/binary_protocol/src/consensus/header.rs 81.56% <ø> (ø)
core/binary_protocol/src/consensus/operation.rs 97.54% <100.00%> (+0.06%) ⬆️
core/server/src/partition_reconciler.rs 97.80% <100.00%> (+0.03%) ⬆️
core/shard/src/metrics.rs 86.55% <ø> (ø)
core/server_common/src/consensus_message.rs 81.80% <85.71%> (+0.50%) ⬆️
core/shard/src/router.rs 80.28% <62.50%> (+7.58%) ⬆️
core/consensus/src/client_table.rs 89.87% <96.59%> (+1.03%) ⬆️

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant