Skip to content

feat(node): support connection string syntax for nodejs client creation - #3917

Open
T1B0 wants to merge 1 commit into
apache:masterfrom
T1B0:add-connection-string-support-node-sdk
Open

feat(node): support connection string syntax for nodejs client creation#3917
T1B0 wants to merge 1 commit into
apache:masterfrom
T1B0:add-connection-string-support-node-sdk

Conversation

@T1B0

@T1B0 T1B0 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR address?

this PR add node sdk support for connection string syntax on client creation
accept common url like syntax new Client("iggy://iggy:iggy@127.0.0.1:8090");

note node:url module was not used since it would have introduced small differencez with rust and other sdk parsing, so connection string is manually parsed to match others sdk behaviors.

@T1B0
T1B0 requested review from hubcio and spetz August 18, 2026 16:15
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 18, 2026
@T1B0
T1B0 force-pushed the add-connection-string-support-node-sdk branch from 2afce42 to e9ffac3 Compare August 18, 2026 16:16
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.26840% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.73%. Comparing base (9f3468b) to head (6a3b7a1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...oreign/node/src/client/client.connection-string.ts 98.11% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3917      +/-   ##
============================================
- Coverage     83.84%   83.73%   -0.12%     
  Complexity     1358     1358              
============================================
  Files          1212     1213       +1     
  Lines        166831   167049     +218     
  Branches     134304   134352      +48     
============================================
- Hits         139887   139885       -2     
- Misses        23305    23524     +219     
- Partials       3639     3640       +1     
Components Coverage Δ
Rust Core 84.61% <ø> (ø)
Java SDK 66.67% <ø> (ø)
C# SDK 76.54% <ø> (ø)
Python SDK 90.00% <ø> (ø)
PHP SDK 84.48% <ø> (ø)
Node SDK 94.10% <98.26%> (-1.84%) ⬇️
Go SDK 68.32% <ø> (ø)
Files with missing lines Coverage Δ
foreign/node/src/client/client.config.ts 100.00% <100.00%> (ø)
foreign/node/src/client/client.socket.ts 95.69% <100.00%> (+<0.01%) ⬆️
foreign/node/src/client/client.ts 97.22% <100.00%> (+0.01%) ⬆️
...oreign/node/src/client/client.connection-string.ts 98.11% <98.11%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@T1B0
T1B0 force-pushed the add-connection-string-support-node-sdk branch 3 times, most recently from 3dae52e to 604cca3 Compare August 19, 2026 18:26
@T1B0
T1B0 force-pushed the add-connection-string-support-node-sdk branch from 604cca3 to 6a3b7a1 Compare August 20, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant