refactor: move password crypto into server_common#3562
Open
jayakasadev wants to merge 1 commit into
Open
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3562 +/- ##
=============================================
- Coverage 74.07% 61.06% -13.01%
Complexity 937 937
=============================================
Files 1249 1247 -2
Lines 128248 117573 -10675
Branches 104116 93487 -10629
=============================================
- Hits 94994 71791 -23203
- Misses 30219 42585 +12366
- Partials 3035 3197 +162
🚀 New features to boost your workflow:
|
jayakasadev
force-pushed
the
phase6-crypto-server-common
branch
from
eb32f00 to
6b41184
Compare
server-ng pulled password hashing and verification from the legacy server crate, forcing a compile-time dependency on the binary it is meant to replace. The crypto module is three free functions over argon2 and rand with no server-internal state, so it relocates cleanly to the shared server_common crate. server keeps the symbols at their original module path via a re-export, so its own call sites are untouched. The argon2 and rand dependencies move with the code, since crypto was their only consumer in server. Refs apache#3315. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jayakasadev
force-pushed
the
phase6-crypto-server-common
branch
from
6b41184 to
5a84ad2
Compare
jayakasadev
changed the title
Contributor
Author
|
/ready |
Contributor
Author
|
/request-review @hubcio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Relates to #3315
Rationale
core/server-ngfrom the legacycore/servercrateWhat changed?
server_commonso I updated the imports inserver-ngto use the new import paths instead ofserver::streaming::utils::crypto)argon2andranddependencies moved with crypto helpers toserver_commonLocal Execution
AI Usage