fix(server): memory leak in segment rotation#2686
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2686 +/- ##
==========================================
+ Coverage 69.69% 69.78% +0.09%
==========================================
Files 568 568
Lines 55229 55238 +9
Branches 55229 55238 +9
==========================================
+ Hits 38492 38550 +58
+ Misses 14859 14809 -50
- Partials 1878 1879 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
Nice. Please modify the segment rotation scenario to include probing for memory used by iggy-server when test ends so we will avoid this problem in future. Set it to some arbitrary value like 200MB. |
mmodzelewski
previously approved these changes
Feb 5, 2026
4adf0e0 to
2f67133
Compare
mmodzelewski
approved these changes
Feb 5, 2026
hubcio
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segment rotation accumulated memory indefinitely because sealed segments retained their 16MB index buffers and kept file writers open. Under heavy write load with frequent rotations, this caused memory to balloon from ~100MB to 20GB+.
The fix clears index buffers for sealed segments (when cache_indexes != All) and closes their writers immediately after sealing. Writers are never needed post-seal, and this also releases io_uring/kernel file handle resources.