feat(connectors): fix state & memory leak, test all plugins, enrich sinks#2685
Open
feat(connectors): fix state & memory leak, test all plugins, enrich sinks#2685
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2685 +/- ##
==========================================
+ Coverage 69.52% 70.35% +0.83%
==========================================
Files 568 568
Lines 55238 55505 +267
Branches 55238 55505 +267
==========================================
+ Hits 38404 39052 +648
+ Misses 14956 14537 -419
- Partials 1878 1916 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mmodzelewski
previously approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connectors runtime lost state on restart - sink connectors resumed from offset 0 instead of their last committed position. The root cause was twofold: consumer group offset queries required membership (which new runtime instances lacked), and stale members from closed TCP connections blocked partition assignment to new members.
Consumer group offset resolution now supports direct queries without membership for ConsumerGroup consumers, since offsets are stored per group+partition, not per member. Stale member cleanup during join removes members whose client connections no longer exist, enabling proper partition rebalancing.
Runtime architecture refactored to fix memory leaks - replaced centralized status manager with DashMap-based SinkManager and SourceManager. Explicit channel cleanup on shutdown prevents dangling references.
State management uses MessagePack serialization for efficient binary persistence. PostgreSQL source fixed to actually return state from poll() and moved database I/O outside mutex to eliminate lock contention.
Additional changes: