fix(server): properly cleanup messages in message cleaner#2670
Merged
fix(server): properly cleanup messages in message cleaner#2670
Conversation
hubcio
changed the title
hubcio
changed the title
messages_cleaner.rs
hubcio
force-pushed
the
messages-cleaner
branch
from
cf02009 to
f0b07bb
Compare
hubcio
changed the title
messages_cleaner.rs
hubcio
force-pushed
the
messages-cleaner
branch
2 times, most recently
from
b9d2bc5 to
0fe9061
Compare
…r default Segments created after server startup were using the server's default message_expiry (NeverExpire) rather than the topic's configured value, causing messages to never be cleaned up even when expiry was set. - Propagate topic's message_expiry to all segment creation sites - Move message_expiry config from [system.segment] to [system.topic] - Remove delete_oldest_segments toggle - Seal segments on rotation so is_expired() can evaluate them - Add comprehensive tests for time-based, size-based, and combined Closes #2629.
hubcio
force-pushed
the
messages-cleaner
branch
from
0fe9061 to
5931d03
Compare
numinnex
approved these changes
Feb 4, 2026
numinnex
approved these changes
Feb 4, 2026
numinnex
approved these changes
Feb 4, 2026
spetz
approved these changes
Feb 4, 2026
krishvishal
pushed a commit
to krishvishal/iggy
that referenced
this pull request
Feb 9, 2026
Segments created after server startup were using the server's default message_expiry (NeverExpire) rather than the topic's configured value, causing messages to never be cleaned up even when expiry was set. - Propagate topic's message_expiry to all segment creation sites - Move message_expiry config from [system.segment] to [system.topic] - Remove delete_oldest_segments toggle - Seal segments on rotation so is_expired() can evaluate them - Add comprehensive tests for time-based, size-based, and combined Closes apache#2629. --------- Co-authored-by: Grzegorz Koszyk <112548209+numinnex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segments created after server startup were using the server's
default message_expiry (NeverExpire) rather than the topic's
configured value, causing messages to never be cleaned up even
when expiry was set.
Closes #2629.