Flink: Support variant for Avro readers and writers - #17737
Open
Guosmilesmile wants to merge 1 commit into
Open
Conversation
Contributor
|
CC: @nssalian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iceberg v3 defines the Avro encoding for variant: a record with
metadataandvaluebinary fields (shredding is not supported in Avro). The core avro layer (ValueWriters.variants()/ValueReaders.variants()) and the Spark bridges (SparkAvroWriter/SparkPlannedAvroReader) already implement this encoding, and the Flink Parquet bridges also support variant.However, the Flink Avro bridges do not:
FlinkAvroWriterandFlinkPlannedAvroReaderdo not overridevariant(), so any read or write of an Avro data file containing a variant column fails with:This pr aim to add support variant for Avro readers and writers.
TestFlinkAvroReaderWriterpasses with the variant round-trip cases enabled (write records / read RowData, and write RowData viaFlinkAvroWriter/ read back viaFlinkPlannedAvroReader).Remove the Miss Feature variant from Avro, and use the file format TCK to test this feature as well.