Core: Add all manifests over-pruning test - #17714
Open
yangshangqing95 wants to merge 1 commit into
Open
Conversation
dramaticlly
reviewed
Aug 18, 2026
| TableScan scan = | ||
| allManifestsTable | ||
| .newScan() | ||
| .filter(Expressions.equal("content", ManifestContent.DATA.id())) |
Contributor
There was a problem hiding this comment.
Can we change the filter ? (either notEqual to DATA.id or equal to DELETES.id())
I think the test goal is that to ensure non-REF_SNAPSHOT_ID based filter + ignoreResiduals shall not prune the scan results. Current predicate of content == 0 return positive result for all 4 snapshots, regardless of setting the ignoreResiduals(),
Contributor
Author
There was a problem hiding this comment.
make sense, changed to
filter(Expressions.equal("content", ManifestContent.DELETES.id()))
anoopj
approved these changes
Aug 19, 2026
uros-b
approved these changes
Aug 19, 2026
yangshangqing95
force-pushed
the
fix/add-test-all-manifests-ignore-residuals-pruning
branch
from
August 19, 2026 20:02
316ce95 to
394135d
Compare
dramaticlly
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17522.
Add coverage to verify that non-snapshot filters do not over-prune snapshots when residuals are ignored.