Data: Split BaseFormatModelTests into read and read-write test classes - #17711
Merged
Conversation
pvary
reviewed
Aug 19, 2026
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.FieldSource; | ||
|
|
||
| public abstract class ReadFormatModelTests<T> { |
pvary
reviewed
Aug 19, 2026
|
|
||
| TestTables.clearTables(); | ||
| } | ||
| public abstract class BaseFormatModelTests<T> extends ReadFormatModelTests<T> { |
Contributor
|
Please add javadoc to the 2 classes. |
Co-authored-by: Joy Haldar <joy.haldar@target.com>
joyhaldar
force-pushed
the
read-format-model-tests
branch
from
August 19, 2026 14:32
4a03fad to
31507f2
Compare
joyhaldar
marked this pull request as ready for review
August 19, 2026 14:35
Guosmilesmile
approved these changes
Aug 20, 2026
pvary
approved these changes
Aug 20, 2026
Contributor
|
Merged to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the format model TCK base class so engines that only support reads can inherit the read tests without the write ones.
ReadFormatModelTestsholds the read tests and shared helpersBaseFormatModelTestsextends it and holds the engine write testsTestSparkFormatModelandTestFlinkFormatModelboth report361 tests / 0 failuresbefore and after the split.Pure refactor, no test bodies changed.