Parquet: Fix boolean filter pushdown UnsupportedOperationException#17093
Open
thswlsqls wants to merge 1 commit into
Open
Parquet: Fix boolean filter pushdown UnsupportedOperationException#17093thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
ParquetFilters.getParquetPrimitive() only handled Number, CharSequence, and ByteBuffer literals, so EQ/NOT_EQ predicates on boolean columns threw UnsupportedOperationException at read-builder construction time instead of returning the matching rows. Boolean literals now take the same cast-and-return path already used for Number. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17092
Summary
ParquetFilters.getParquetPrimitive()handledNumber,CharSequence, andByteBufferliterals but notBoolean, soEQ/NOT_EQpredicates on boolean columns threwUnsupportedOperationExceptionwhile building the Parquet read builder, failing the read before any rows were returned.Booleanto the existingNumberbranch (direct cast, same pattern), sinceFilterApi.eq(BooleanColumn, Boolean)expects the literal as-is.Testing done
TestParquet#booleanEqualityFilterPushdownandTestParquet#booleanInequalityFilterPushdown, each writing a boolean-column Parquet file and reading it back throughParquet.read(...).filter(...), asserting the correct rows are returned instead of throwing../gradlew :iceberg-parquet:check— 705 tests passed (0 failures/errors), spotlessCheck/checkstyle/revapi included../gradlew :iceberg-parquet:revapi— passed (no public API change;ParquetFiltersis package-private,getParquetPrimitiveis private static).