Docs: Fix type mismatch in JDBC catalog Java API example#17086
Open
thswlsqls wants to merge 1 commit into
Open
Docs: Fix type mismatch in JDBC catalog Java API example#17086thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
CatalogUtil.buildIcebergCatalog(...) returns Catalog, not JdbcCatalog. The example assigned the result directly to a JdbcCatalog variable without a cast, which fails to compile. Add the explicit cast. Generated-by: Claude Code
ebyhr
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17083
Summary
CatalogUtil.buildIcebergCatalog(...)'s result directly to aJdbcCatalogvariable, but the method's only declared return type isCatalog, causing an "incompatible types" compile error.(JdbcCatalog)cast so the example compiles as written.Testing done
core/src/main/java/org/apache/iceberg/CatalogUtil.javaline 312 (public static Catalog buildIcebergCatalog(...)).