Dell: Handle EOF in EcsSeekableInputStream reads#17065
Open
thswlsqls wants to merge 1 commit into
Open
Conversation
read() and read(byte[], int, int) advanced pos and incremented the read metrics before checking whether the underlying stream returned EOF (-1), violating the InputStream contract and, for the bulk read overload, decrementing the read-bytes counter by 1 on every EOF. S3, ADLS, and GCS input streams were already fixed the same way in apache#16055; Dell's ECS-backed stream was the one implementation left behind (tracked by issue apache#16062, PR apache#16266 closed by stale-bot with no committer objection). Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #16062
Summary
EcsSeekableInputStream.read()andread(byte[], int, int)advancedposand incremented the read metrics before checking whether the underlying stream returned EOF (-1), violating theInputStreamcontract.readBytes.increment(-1)decremented the counter on every EOF instead of leaving it unchanged.Testing done
TestEcsSeekableInputStream#readAtEndOfStreamReturnsEofWithoutAdvancingPosand#readBytesAtEndOfStreamReturnsEofWithoutAdvancingPoscovering EOF for bothread()andread(byte[], int, int)../gradlew :iceberg-dell:check— 6 tests passed (4 existing + 2 new), spotlessCheck/checkstyle passed.