GCP: Fix listNamespaces to return empty list for existing namespaces#17060
Open
thswlsqls wants to merge 1 commit into
Open
GCP: Fix listNamespaces to return empty list for existing namespaces#17060thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
listNamespaces(Namespace) always threw NoSuchNamespaceException for any non-empty argument, even when the namespace existed. This contradicted the method's own Javadoc, which says an existing single-level namespace returns an empty list (BigQuery only supports one-level namespaces, so no sub-namespaces exist). Check namespaceExists(namespace) before throwing, mirroring HiveCatalog#listNamespaces(Namespace). Generated-by: Claude Code
ebyhr
approved these changes
Jul 3, 2026
ebyhr
left a comment
ebyhr
left a comment
Member
There was a problem hiding this comment.
This introduces an additional datasets.get RPC call, but I believe this change is reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17058
Summary
listNamespaces(Namespace)threwNoSuchNamespaceExceptionfor any non-empty namespace, even existing ones, contradicting its own Javadoc ("always returns an empty list" for an existing single-level namespace).namespaceExists(namespace): returnsImmutableList.of()if it exists, throws only if it does not.HiveCatalog#listNamespaces(Namespace)(hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java line 530-537), which uses the same existence-check-then-throw pattern.Testing done
TestBigQueryCatalog#testListNamespacesWithExistingNamespaceReturnsEmptyListcovering the existing-namespace case../gradlew :iceberg-bigquery:check— 110 tests, 0 failures, 0 errors (23 skipped, pre-existing@Disabledcases unrelated to this change).