Core: Clean up encryption keys as part of RemoveSnapshots#16353
Open
Hugo-WB wants to merge 1 commit into
Open
Conversation
Hugo-WB
force-pushed
the
cleanup-encryption-keys
branch
from
3166d6c to
3d534d6
Compare
Contributor
Author
|
@ggershinsky curious to hear your thoughts on above. Specifically the questions I left in the PR description. Thanks! |
Contributor
|
sgtm. manifest list file keys are generated per snapshot, and are not re-used. if a snapshot is removed, no reason to keep its key. |
Contributor
Author
|
sounds good. @huaxingao could I get a review on the above please! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first part of: #16352 for
ExpireSnapshotsBy calling
removeEncryptionKeywhen we remove snapshot from metadata.This assumes that snapshot <> encryption key is 1:1. I think this is a valid assumption given a new encryption key is created per manifest list here? But keen to get thoughts from others on this invariant, I am relatively unfamiliar with all this. Do people know what the intention here was? Are there cases where key re-use could happen?