Core: Remove @Deprecated from MetricsConfig.fromProperties#15819
Open
ebyhr wants to merge 1 commit intoapache:mainfrom
Open
Core: Remove @Deprecated from MetricsConfig.fromProperties#15819ebyhr wants to merge 1 commit intoapache:mainfrom
@Deprecated from MetricsConfig.fromProperties#15819ebyhr wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@szehon-ho Could you please review this PR when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is used from Trino (IcebergPageSink), and migrating it to
forTable(Table table)is a bit difficult since Table isn't available in this class. Additionally, MetricsConfig isn't Jackson-serializable.I propose reverting the deprecation, though I'm open to alternative approaches, e.g. exposing a method of 3 parameters
(Map<String, String> props, Schema schema, SortOrder order)