Spark 4.1: Add ResolveBranch path identifier tests#15816
Open
manuzhang wants to merge 1 commit intoapache:mainfrom
Open
Spark 4.1: Add ResolveBranch path identifier tests#15816manuzhang wants to merge 1 commit intoapache:mainfrom
manuzhang wants to merge 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Spark 4.1 test coverage to ensure Iceberg’s ResolveBranch analyzer rule correctly “pins” the resolved branch into DSv2 path-based identifiers (including metadata selector paths), so refreshes keep targeting the intended branch.
Changes:
- Introduces
TestResolveBranchvalidating branch resolution for path-based reads when WAP is enabled. - Verifies
PathIdentifier.locationformatting for both plain paths (#branch_<name>) and metadata-selector paths (#files,branch_<name>).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manuzhang
force-pushed
the
spark-resolve-branch-tests
branch
2 times, most recently
from
b704b59 to
eaa0b8a
Compare
Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
spark-resolve-branch-tests
branch
from
eaa0b8a to
eb2e2a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.