Flink: Remove JUnit4 dependency from Flink modules#15815
Open
sachinnn99 wants to merge 1 commit intoapache:mainfrom
Open
Flink: Remove JUnit4 dependency from Flink modules#15815sachinnn99 wants to merge 1 commit intoapache:mainfrom
sachinnn99 wants to merge 1 commit intoapache:mainfrom
Conversation
Remove the explicit flink-test-utils-junit dependency from all three Flink version modules (v1.20, v2.0, v2.1). All Flink test code has already been migrated to JUnit5 in prior work, making this dependency vestigial. The artifact remains available transitively through flink-test-utils and flink-connector-test-utils. Also removes the corresponding library aliases from libs.versions.toml. Fixes apache#12937
sachinnn99
force-pushed
the
flink-remove-junit4-dep
branch
from
8fef98b to
a4f3b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the explicit
flink-test-utils-junitdependency from all three Flink version modules (v1.20, v2.0, v2.1) and clean up the corresponding library aliases fromlibs.versions.toml.Why
All Flink test code has already been migrated to JUnit5 in prior work (#13021, #10770), making the explicit
flink-test-utils-junitdependency vestigial. The artifact remains available transitively throughflink-test-utilsandflink-connector-test-utils.Changes
flink/v1.20/build.gradle,flink/v2.0/build.gradle,flink/v2.1/build.gradle: Removed explicitflink-test-utils-junitdependencygradle/libs.versions.toml: Removed 3 unusedflink-test-utils-junitlibrary aliasesNote
This does not fully resolve #12937. JUnit4 (
junit:junit) still reaches the test classpath transitively throughflink-connector-test-utilsandflink-test-utils, because Flink's internal test utilities still referenceorg.junit.rules.ExternalResourceat runtime. Fully removing JUnit4 requires upstream changes in Flink first.