Arrow: Fix NullabilityHolder.reset() to clear the isNull array #15809
Open
thswlsqls wants to merge 1 commit intoapache:mainfrom
Open
Arrow: Fix NullabilityHolder.reset() to clear the isNull array #15809thswlsqls wants to merge 1 commit intoapache:mainfrom
thswlsqls wants to merge 1 commit intoapache:mainfrom
Conversation
NullabilityHolder.reset() only reset the numNulls counter to zero but did not clear the isNull byte array, leaving stale null markers from the previous batch. This could cause isNullAt() to return incorrect results after a reset if the caller did not explicitly overwrite every position. Clear the isNull array in reset() to ensure consistent state.
Contributor
|
Could you add AI disclosure to this PR? Same for all your other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15808
reset()clearsnumNullsbut not theisNullbyte array. Current callers always overwrite all positions on the next batch, so stale data is not observed today - butreset()should restore a clean initial state to avoid a trap for future callers.Fix: add
Arrays.fill(isNull, (byte) 0)inreset(). The other two arrays (nulls,nonNulls) are immutablearraycopysource buffers and do not need clearing.