Core, Data: Implementation of AvroFormatModel #15254
Open
+540
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Feb 10, 2026
core/src/main/java/org/apache/iceberg/avro/AvroFormatModel.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 10, 2026
rdblue
reviewed
Feb 10, 2026
data/src/main/java/org/apache/iceberg/data/GenericFormatModels.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 10, 2026
data/src/main/java/org/apache/iceberg/data/GenericFormatModels.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 10, 2026
data/src/test/java/org/apache/iceberg/data/TestGenericFormatModels.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 10, 2026
| DataTestHelpers.assertEquals( | ||
| TestBase.SCHEMA.asStruct(), TEST_RECORDS.get(0), readRecords.get(0)); | ||
| DataTestHelpers.assertEquals( | ||
| TestBase.SCHEMA.asStruct(), TEST_RECORDS.get(1), readRecords.get(1)); |
Contributor
There was a problem hiding this comment.
Minor: I'd prefer a loop here so that we could add more cases or pass a random data generator.
Contributor
Author
There was a problem hiding this comment.
Added random generated data and moved to looped check.
Please check the changes in DataTestHelpers
rdblue
reviewed
Feb 10, 2026
data/src/test/java/org/apache/iceberg/data/TestGenericFormatModels.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 10, 2026
data/src/test/java/org/apache/iceberg/data/TestGenericFormatModels.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 10, 2026
data/src/test/java/org/apache/iceberg/data/TestGenericFormatModels.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 10, 2026
core/src/main/java/org/apache/iceberg/avro/AvroFormatModel.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #12298
Implementation of the new API: #12774
AvroFormatModel and related tests